8000 Draft moving model init into Engines · Issue #119 · MantisAI/sieves · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Draft moving model init into Engines #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rmitsch opened this issue Apr 5, 2025 · 0 comments
Open

Draft moving model init into Engines #119

rmitsch opened this issue Apr 5, 2025 · 0 comments
Assignees
@rmitsch
Labels
engines Everything related to engines scope: L Estimated effort: large

Comments

@rmitsch
Copy link
Collaborator
rmitsch commented Apr 5, 2025 •
edited
Loading
  • Set default model for each engine
  • init_kwargs -> generator_init_kwargs
  • Optional model_provider arg
  • Rename Engine into Model?
  • Engine shouldn't be InternalEngine
  • Trickiest refactoring: Instructor. Do last. Collect all providers dynamically. Instantiate client arg type with provided model_init_kwargs -> doesn't work, see e.g. LiteLLM. Alternative? - Require passing of instantiated client? Instantiate manually with local imports?
@rmitsch rmitsch added engines Everything related to engines scope: L Estimated effort: large labels Apr 5, 2025
@rmitsch rmitsch self-assigned this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmitsch rmitsch

Labels
engines Everything related to engines scope: L Estimated effort: large
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmitsch
0