8000 feat: Improve Handling of Multi-Line Strings with Triple Quotes by koxudaxi · Pull Request #113 · Mirascope/lilypad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Improve Handling of Multi-Line Strings with Triple Quotes #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 23, 2025
Merged

feat: Improve Handling of Multi-Line Strings with Triple Quotes #113

merged 12 commits into from
Jan 23, 2025

Conversation

koxudaxi
Copy link
Collaborator

Closes: #85

@koxudaxi koxudaxi requested review from brenkao and willbakst January 17, 2025 07:57
willbakst
willbakst reviewed Jan 22, 2025
View reviewed changes
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying lilypad-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76637b1
Status: ✅  Deploy successful!
Preview URL: https://336a41fb.lilypad-website-et1.pages.dev
Branch Preview URL: https://improve-triple-quote-multili.lilypad-website-et1.pages.dev

View logs

@koxudaxi
Copy link
Collaborator Author

@willbakst
I made minimal changes to switch from AST to libCST implementation.

I tried reimplementing other AST-inherited classes using libCST as well, but they didn't work properly. This is probably because the behavior of visit functions for each node is different between AST and libCST. I feel we need either fine-tuning of the implementation or a redesign of the architecture.

Since these minimal changes achieve our current goals, I think we don't need to touch other parts for now.

@koxudaxi koxudaxi requested a review from willbakst January 23, 2025 13:18
willbakst
willbakst reviewed Jan 23, 2025
View reviewed changes
@willbakst willbakst merged commit 9a8482a into main Jan 23, 2025
8 checks passed
@willbakst willbakst deleted the improve-triple-quote-multiline-handling branch January 23, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbakst willbakst willbakst approved these changes

@brenkao brenkao Awaiting requested review from brenkao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard to review long prompts
2 participants
@koxudaxi @willbakst
0