8000 Remove s3 install instructions by ppinchuk · Pull Request #536 · NREL/reV · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove s3 install instructions #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Conversation

ppinchuk
Copy link
Collaborator

S3 package requirements are now always bundled with rex, and so we get them by default. No need for any extra installation, so I am removing references to that in our documentation (these break anyways, since we no longer have an s3 feature in our pyproject.toml)

@ppinchuk ppinchuk added documentation Improvements or additions to documentation enhancement Update to logic or general code improvements p-low Priority: low labels Apr 25, 2025
@ppinchuk ppinchuk added this to the Repo updates milestone Apr 25, 2025
@ppinchuk ppinchuk self-assigned this Apr 25, 2025
@ppinchuk ppinchuk changed the title Pp/remove s3 install instructions Remove s3 install instructions Apr 25, 2025
@ppinchuk ppinchuk merged commit d7b0f48 into main Apr 25, 2025
11 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 25, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.55%. Comparing base (dfe305c) to head (8d82296).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files          62       62           
  Lines       11105    11105           
  Branches     1602     1602           
=======================================
  Hits         8835     8835           
  Misses       1781     1781           
  Partials      489      489           
Flag Coverage Δ
unittests 79.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk deleted the pp/remove_s3_install_instructions branch May 4, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Update to logic or general code improvements p-low Priority: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0