8000 fix: error in RunnableRails with tracing enabled by thisthat · Pull Request #1103 · NVIDIA/NeMo-Guardrails · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: error in RunnableRails with tracing enabled #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thisthat
Copy link
Contributor
@thisthat thisthat commented Apr 8, 2025

Description

Removes changing the response in case tracing is enabled.

Related Issue(s)

Fixes #1093

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@trebedea trebedea assigned trebedea and unassigned trebedea Apr 8, 2025
@trebedea trebedea requested review from trebedea and Pouyanpi April 8, 2025 13:21
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat marked this pull request as ready for review April 8, 2025 13:29
Copy link
Collaborator
@trebedea trebedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my side. Thanks for adding the test as well.

@trebedea
Copy link
Collaborator
trebedea commented Apr 8, 2025

Hi @thisthat ,

The MR looks great, but it missing the black formatting for the new test. Can you fix this to be able to merge?

Thanks!

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Copy link
Collaborator
@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thisthat! LGTM!

@Pouyanpi Pouyanpi self-requested a review April 9, 2025 08:22
@Pouyanpi Pouyanpi merged commit 748e9cd into NVIDIA:develop Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Nemo Guardrail crashes when tracing is enabled
3 participants
0