fix(config): correct dialog rails activation logic #1161
Conversation
Fixed the `has_dialog_rails` logic in `RailsConfig` to require both `user_messages` and `bot_messages` for implicit activation. Removed `flows` from the condition to align with expected behavior. test(config): adjust tests for updated dialog rails logic Modified test cases to reflect the corrected dialog rails activation logic.
Thank you, @trebedea , for the review. I ran into some issues because the generate_user_intent action doesn’t just generate the user intent (it also produces the bot message and passthrough). So, I wasn’t able to identify the correct mapping from the config to the dialog rails tasks to prevent this behavior while still allowing it when it’s explicitly removed at the task level. Please let me know if there’s a way we can fix/improve this validation. We can also add tests in #1145 to ensure all scenarios are handled correctly. Thanks! |
63a18a9 to
836008d
Compare
Whenever we have any of user_messages, flows, or bot_messages in the config, we can consider has_dialog_rails is potentially True. In some cases, dialogue rails will not be triggered, e.g. if we have user_messages and embeddings_only is set to True. |
Description
Fixed the
has_dialog_railslogic inRailsConfigto require bothuser_messagesandbot_messagesfor implicit activation. Removedflowsfrom the condition to align with expected behavior.test(config): adjust tests for updated dialog rails logic
Modified test cases to reflect the corrected dialog rails activation logic.
Related PR
#1137