relnotes: init at 0.1.2 #277438
Open
relnotes: init at 0.1.2 #277438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package built:
|
066afc6 to
491c2ee
Compare
AndersonTorres
suggested changes
Dec 29, 2023
|
|
AndersonTorres
suggested changes
Jan 24, 2024
AndersonTorres
suggested changes
Jun 19, 2024
AndersonTorres
approved these changes
Aug 11, 2024
|
@ofborg build relnotes |
Aleksanaa
approved these changes
Sep 9, 2024
FliegendeWurst
approved these changes
Dec 5, 2024
Comment on lines
+26
to
+28
| buildInputs = | ||
| lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ] | ||
| ++ lib.optionals stdenv.isLinux [ (lib.getDev openssl) ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = | |
| lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ] | |
| ++ lib.optionals stdenv.isLinux [ (lib.getDev openssl) ]; | |
| buildInputs = lib.optionals stdenv.hostPlatform.isLinux [ (lib.getDev openssl) ]; |
I think the Darwin stuff is included automatically by now.
|
| ]; | ||
| mainProgram = "relnotes"; | ||
| maintainers = with lib.maintainers; [ david-r-cox ]; | ||
| platforms = lib.platforms.darwin; |
There was a problem hiding this comment.
Should this be more than just darwin?
Otherwise the conditional above for linux/darwin buildInputs doesn't make much sense to me.
Suggested change
| platforms = lib.platforms.darwin; | |
| platforms = lib.platforms.unix; |
There was a problem hiding this comment.
Linux failed due to sfackler/rust-openssl#1663
Probably better to set platforms as unix and mark linux as broken.
There was a problem hiding this comment.
I see #277438 (comment), so maybe make the platforms unix and mark the package as broken for linux instead?
| @@ -0,0 +1,46 @@ | |||
| { | |||
| darwin, | |||
There was a problem hiding this comment.
Currently we use Apple SDK.
Try to remove references to Darwin on the code.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.