8000 Remove bit64 from package · Issue #152 · OHDSI/CohortGenerator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove bit64 from package #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anthonysena opened this issue May 30, 2024 · 2 comments · Fixed by #159
Closed

Remove bit64 from package #152

anthonysena opened this issue May 30, 2024 · 2 comments · Fixed by #159
Milestone
v0.10

Comments

@anthonysena
Copy link
Collaborator

The bit64 package was introduced to address issues in #51 but this package is not recommended due to problems with integer64 values. This work should be done after #151 to ensure these changes to not cause breaking changes to Google BigQuery and other platforms.
@anthonysena anthonysena added this to the v0.10 milestone May 30, 2024
@anthonysena anthonysena mentioned this issue Jun 5, 2024
Closed
@anthonysena
Copy link
Collaborator Author

Cannot remove bit64 entirely until we remove the insertInclusionRuleNames function from the package. At the moment we use DatabaseConnector::insertTable to insert the inclusion rules and the cohortDefinitionId must be an integer64 otherwise it will break Google BigQuery.

@anthonysena
Copy link
Collaborator Author

Linking to #158 so we can address this in the first major release. I'll remove parts of the code that use bit64 where possible.

@anthonysena anthonysena mentioned this issue Jun 5, 2024
Merged
@anthonysena anthonysena linked a pull request Jun 5, 2024 that will close this issue
Revise to use numeric for nco cohorts #159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

Revise to use numeric for nco cohorts OHDSI/CohortGenerator
1 participant
@anthonysena
0