8000 Debug should not break XML/JSON · Issue #25583 · Automattic/jetpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Debug should not break XML/JSON #25583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kraftbj opened this issue Dec 1, 2015 · 4 comments · May be fixed by Automattic/wp-super-cache#436
Open

Debug should not break XML/JSON #25583

kraftbj opened this issue Dec 1, 2015 · 4 comments · May be fixed by Automattic/wp-super-cache#436
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Super Cache] REST API [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@kraftbj
Copy link
Contributor
kraftbj commented Dec 1, 2015

We should probably not output any debug messages if DOING_AJAX, XMLRPC_REQUEST, or REST_REQUEST.
@iandunn
Copy link
iandunn commented Dec 30, 2015

It'd be good to also include JSON_REQUEST in this and 02d6a8e, for those running v1 of the REST API.

Related Automattic/wp-super-cache#22

@iandunn
Copy link
iandunn commented Jun 8, 2016

Actually, I don't think v1 support is all that important anymore. I think most custom v1 endpoints have migrated to v2, or will soon.

iandunn referenced this issue in iandunn/wp-super-cache Jun 8, 2016
@iandunn
Cache REST API endpoints.
ddb3590 
Fixes Automattic#22
Fixes Automattic#114
See #79
iandunn referenced this issue in iandunn/wp-super-cache Aug 3, 2016
@iandunn
Add plugin to cache WordPress' REST API endpoints.
0f24a2a 
Fixes Automattic#22
Fixes Automattic#114
See #79
This was referenced Nov 29, 2016
Closed
Closed
iandunn referenced this issue in iandunn/wp-super-cache Feb 15, 2017
@iandunn
Add plugin to cache WordPress' REST API endpoints.
72175f9 
Fixes Automattic#22
Fixes Automattic#114
See #79
iandunn referenced this issue in iandunn/wp-super-cache Feb 15, 2017
@iandunn
Add plugin to cache WordPress' REST API endpoints.
386f47b 
Fixes Automattic#22
Fixes Automattic#114
See #79
iandunn referenced this issue in iandunn/wp-super-cache Feb 15, 2017
@iandunn
Add plugin to cache WordPress' REST API endpoints.
6bb7871 
Fixes Automattic#22
Fixes Automattic#114
See #79
iandunn referenced this issue in iandunn/wp-super-cache Feb 15, 2017
@iandunn
Add plugin to cache WordPress' REST API endpoints.
0e1704f 
Fixes Automattic#22
Fixes Automattic#114
See #79
@jom
Copy link
Member
jom commented Oct 26, 2017

ref: wp_cache_add_to_buffer()
https://github.com/Automattic/wp-super-cache/blob/f4cab722d73b88bac12042e2865be1fd3dc5042c/wp-cache-phase2.php#L593-L608

@donnchawp
Copy link
Contributor
donnchawp commented Oct 26, 2017 •
edited
Loading

While that strpos will more than likely stop the plugin writing out html comments to non-html content we could also add in checks for those constants. I merged in a change that checked for various REST protocols yesterday, so the wp_cache_add_to_buffer() function could do something similar..

https://github.com/Automattic/wp-super-cache/blob/f4cab722d73b88bac12042e2865be1fd3dc5042c/wp-cache-phase2.php#L377-L380

@jom jom self-assigned this Oct 27, 2017
@jom jom linked a pull request Oct 27, 2017 that will close this issue
Open
@kraftbj kraftbj added the [Plugin] Super Cache A fast caching plugin for WordPress. label Aug 12, 2022
@kraftbj kraftbj transferred this issue from Automattic/wp-super-cache Aug 12, 2022
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Super Cache] REST API and removed enhancement labels Aug 12, 2022
@jom jom removed their assignment Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Super Cache] REST API [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide debug output for REST or Ajax requests Automattic/wp-super-cache
5 participants
@jom @kraftbj @jeherve @iandunn @donnchawp
0