8000 Test case failing with unauthenticated repair feature · Issue #248 · ANSSI-FR/MLA · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test case failing with unauthenticated repair feature #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
extiop opened this issue Mar 2, 2025 · 0 comments
Open

Test case failing with unauthenticated repair feature #248

extiop opened this issue Mar 2, 2025 · 0 comments
Labels
bug Something isn't working mlar Concerns the mlar utility tests Relative to the testing capabilities

Comments

@extiop
Copy link
Contributor
extiop commented Mar 2, 2025 •
edited
Loading

Fails like https://github.com/ANSSI-FR/MLA/actions/runs/12364423067/job/34507635501?pr=227 and https://github.com/ANSSI-FR/MLA/actions/runs/12364423067/job/34507634605?pr=227 are explained most likely explained by https://github.com/ANSSI-FR/MLA/blob/master/mlar/tests/integration.rs#L46. Indeed, when file3.bin from the setup() is used in test_repair_auth_unauth() integration test, the input to mlar is 10 bytes. Thereby, it fails the test as unauthenticated read data is equal to authenticated read data, which is 10, failing here https://github.com/ANSSI-FR/MLA/blob/master/mlar/tests/integration.rs#L547.

Thus, the feature (unauthenticated and authenticated data from repair cf. #222) works well but fixing this problem is preferable.

The reason is still not well diagnosed.

First identified there: #227 (comment)
@extiop extiop added bug Something isn't working CI Relative to the Continuous Integration labels Mar 2, 2025
@extiop extiop added this to the mla v1.5.0 milestone Mar 2, 2025
@extiop extiop added tests Relative to the testing capabilities mlar Concerns the mlar utility and removed CI Relative to the Continuous Integration labels Apr 8, 2025
@extiop extiop changed the title Minor side effect with unauthenticated repair feature Test case failing with unauthenticated repair feature Apr 8, 2025
@extiop extiop modified the milestones: mla v1.5.0, mla v2.0.0 Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working mlar Concerns the mlar utility tests Relative to the testing capabilities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@extiop
0