8000 Hardcoded default ClickHouse and Keeper images · Issue #1677 · Altinity/clickhouse-operator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hardcoded default ClickHouse and Keeper images #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
juan131 opened this issue Apr 9, 2025 · 6 comments
Open

Hardcoded default ClickHouse and Keeper images #1677

juan131 opened this issue Apr 9, 2025 · 6 comments

Comments

@juan131
Copy link
juan131 commented Apr 9, 2025

The default ClickHouse and Keeper container images are hardcoded, see:

They should be customizable via env. variables (e.g. CLICKHOUSE_CONTAINER_IMAGE and KEEPER_CONTAINER_IMAGE) so these default values can be overwritten. AFAIK, only the env. vars defined below are currently supported.
@alex-zaitsev
Copy link
Member

You can always override images in the podTemplate. This is better than environment variables. Why do you want to use those?

@juan131
Copy link
Author
juan131 commented Apr 14, 2025

Hi @alex-zaitsev

That's true by it doesn't change the default behavior. My use case: I want to ensure all the developers use a very specific image tag is used (relying on latest which is a rolling tag isn't suitable for my production environment).

@alex-zaitsev
Copy link
Member

You may used templates to make it easier for your devs, but adding support for env variables is an easy change as well:

apiVersion: "clickhouse.altinity.com/v1"
kind: "ClickHouseInstallationTemplate"

metadata:
  name: clickhouse-version
spec:
  defaults:
    templates:
      podTemplate: default
  templates:
    podTemplates:
      - name: default
        spec:
          containers:
            - name: clickhouse-pod
              image: clickhouse/clickhouse-server:24.8.14.39
              imagePullPolicy: IfNotPresent

@juan131
Copy link
Author
juan131 commented Apr 14, 2025

Yes, pod templates are also a way to reduce the risks for this use case. That said, being able to configure the default images is quiet a common thing on operators. For instance:

@alex-zaitsev
Copy link
Member

Planned for 0.26.x

@juan131
Copy link
Author
juan131 commented Apr 29, 2025

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juan131 @alex-zaitsev
0