Description
Given #133, and how widespread this crate is to the ecosystem, semver related bugs should not be taken lightly.
Perhaps CI could check for the common offenders using cargo-semver-check.
Running a test locally, cargo semver-checks did catch the bug in 133
$ cargo semver-checks --default-features
Updating index
Parsing memchr v2.6.0 (current)
Parsing memchr v2.5.0 (baseline)
Checking memchr v2.5.0 -> v2.6.0 (minor change)
Completed [ 0.023s] 39 checks; 38 passed, 1 failed, 6 unnecessary
--- failure auto_trait_impl_removed: auto trait no longer implemented ---
Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
impl: https://github.com/obi1kenobi/cargo-semver-check/tree/v0.22.1/src/lints/auto_trait_impl_removed.ron
Failed in:
type Memchr3 is no longer Sync, in /tmp/memchr/src/memchr.rs:432
type Memchr3 is no longer Send, in /tmp/memchr/src/memchr.rs:432
type Memchr is no longer Sync, in /tmp/memchr/src/memchr.rs:288
type Memchr is no longer Send, in /tmp/memchr/src/memchr.rs:288
type Memchr2 is no longer Sync, in /tmp/memchr/src/memchr.rs:364
type Memchr2 is no longer Send, in /tmp/memchr/src/memchr.rs:364
Final [ 0.026s] semver requires new major version: 1 major and 0 minor checks failed
cc @obi1kenobi