Registration Service attempts to get form from service locator when it is actually part of the form element manager #23

AydinHassan · 2013-07-26T21:51:52Z

I was looking over the code and noticed that the registration form factory is defined in the form element manager configuration:

https://github.com/Bacon/BaconUser/blob/master/config/module.config.php#L40

However, the form registration service attempts to get the form from the service manager: https://github.com/Bacon/BaconUser/blob/master/src/BaconUser/Service/Factory/RegistrationServiceFactory.php#L31

There is no 'BaconUser\Form\RegistrationForm' key in the service manager configuration. I'm sure the form should be instantiated by the form element manager:

Like so:
$serviceLocator->get('FormElementManager')->get('BaconUser\Form\RegistrationForm')

I could be wrong and haven't tested anything, merely an observation.

DASPRiD · 2013-07-27T17:44:44Z

That's probably right. We are currently working on rewriting some parts, so there may be inconsistencies right now.

AydinHassan · 2013-07-28T18:37:28Z

Yeah sure, I just noticed and ocramius asked me to create an issue.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Registration Service attempts to get form from service locator when it is actually part of the form element manager #23

Registration Service attempts to get form from service locator when it is actually part of the form element manager #23

Registration Service attempts to get form from service locator when it is actually part of the form element manager #23

Registration Service attempts to get form from service locator when it is actually part of the form element manager #23

Comments