8000 Missing `checkbashisms` script creates warning from running check · Issue #34 · Bioconductor/bioconductor_docker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Missing checkbashisms script creates warning from running check #34
Open
@omsai

Description

@omsai

I'm careful to squash any warnings output by running CRAN's check on my package with CI. After many warning-free builds, I just added a configure script to my package and noticed a warning generated [1]

* checking top-level files ... WARNING
A complete check needs the 'checkbashisms' script.
See section ‘Configure and cleanup’ in the ‘Writing R Extensions’
manual.

... from the docker image bioconductor/bioconductor_docker:RELEASE_3_13 presumably because it finds my configure script but the image does not include the perl script checkbashisms [2] to confirm that configure does not use non-portable shell syntax.

Would it make sense for you to install the checkbashisms command in the image so that check works out of the box for packages with configure scripts? Your docker image runs Ubuntu 20.04, so you'll need to install the devscripts package to install checkbashisms.

I confirmed on my local Debian machine that I also see the warning, and that installing the devscripts package makes the warning go away.

I don't see devscripts in your current Dockerfile [3].

[1] https://gitlab.com/coregenomics/tsshmm/-/jobs/1541592549#L197

[2] https://cran.r-project.org/doc/manuals/r-release/R-exts.html#FOOT26

[3] https://github.com/Bioconductor/bioconductor_docker/blob/master/Dockerfile

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0