8000 How to decide `minSubmissionValue` and `maxSubmissionValue`? · Issue #90 · Bisonai/orakl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

How to decide minSubmissionValue and maxSubmissionValue? #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martinkersner opened this issue Jan 5, 2023 · 3 comments · Fixed by #208
Closed

How to decide minSubmissionValue and maxSubmissionValue? #90

martinkersner opened this issue Jan 5, 2023 · 3 comments · Fixed by #208
Assignees
@martinkersner
Labels
aggregator on-chain question Further information is requested
Milestone
7th KF Meeting - 1

Comments

@martinkersner
Copy link
Member

No description provided.

@martinkersner martinkersner added question Further information is requested on-chain labels Jan 5, 2023
@martinkersner martinkersner added this to the 6th KF Meeting milestone Jan 16, 2023
@KelvinThai
Copy link
Contributor

These 2 parameters set the boundary for off-chain oracles when they submit results to on-chain aggregator.
The value should be set depending on what kind of data is being submitted. Eg. For stable coin price, the price can fluctuate but can not be 2 $/stabelcoin. Chainlink marks this as immutable, we can not change it after initialization.
For our current adapter which is KLAY/USD. we can set that from 1 to the biggest of it datatype. who knows what the price can be in the future.

@martinkersner
Copy link
Member Author

Thank you! Let me think about this until tomorrow and we can have a call make decision tomorrow!

@martinkersner
Copy link
Member Author

After discussion with Kelvin, we decided to remove minSubmissionValue and maxSubmissionValue from Aggregator for now. However, we understand the need for checking submitted values. We will keep thinking about this problem and try to come up with a better solution than hardcoded immutable constants.

cc @KelvinThai @bayram98

@martinkersner martinkersner linked a pull request Feb 4, 2023 that will close this issue
Remove min and max submission value in for Aggregator #208
Merged
@martinkersner martinkersner mentioned this issue Feb 4, 2023
Merged
Sign up for free to join t 5444 his conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinkersner martinkersner

Labels
aggregator on-chain question Further information is requested
Projects
None yet
Milestone
7th KF Meeting - 1
Development

Successfully merging a pull request may close this issue.

Remove min and max submission value in for Aggregator Bisonai/orakl
3 participants
@martinkersner @bayram98 @KelvinThai
0