8000 Clean up e2e test dockerfile · Issue #426 · CERT-Polska/mquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000
Clean up e2e test dockerfile #426
Open
@msm-cert

Description

@msm-cert

Right now this setup is needlessly complicated:

      - name: run web with docker compose
        run: docker compose up --build -d web --wait
      - name: init the database
        run: docker compose exec -it -w /usr/src/app/src/ web alembic upgrade head
      - name: run the rest of the code
        run: docker compose up -d
      - name: run e2e tests
        run: docker run --net mquery_default -v $(readlink -f ./samples):/mnt/samples mquery_tests

specifically, this line is probably unnecessary, and we can start everything at once:

 -name: init the database
     run: docker compose exec -it -w /usr/src/app/src/ web alembic upgrade head

But before removing it we should make sure there are no race conditions and e2e tests still work.

It's possible that just this is enough for setup:

 docker compose up --build -d --wait

(and then run mquery_tests)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0