8000 Fix issues uncovered from original `mustache-to-twig` branch by DAcodedBEAT · Pull Request #6978 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issues uncovered from original mustache-to-twig branch #6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2024
Merged

Fix issues uncovered from original mustache-to-twig branch #6978

merged 3 commits into from
May 2, 2024

Conversation

DAcodedBEAT
Copy link
Contributor
@DAcodedBEAT DAcodedBEAT commented May 1, 2024 •
edited
Loading

Description & Issue number it closes

The original branch was merged but when running locally, I noticed that there were issues in the composer.lock file, function signatures not matching between classes, and PSR namespaces not matching directory structure.

While here, I added types to keep a pulse check on modernizing the codebase.

Closes #6643

Screenshots (if appropriate)

(no change)
image

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@DAcodedBEAT DAcodedBEAT added Code Smell php Pull requests that update Php code labels May 1, 2024
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner May 1, 2024 11:02
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team May 1, 2024 11:02
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.8.0) milestone May 1, 2024
@DAcodedBEAT DAcodedBEAT mentioned this pull request May 1, 2024
Merged
12 tasks
@DawoudIO DawoudIO merged commit 02b861b into master May 2, 2024
4 checks passed
@DawoudIO DawoudIO deleted the mustache-to-twig branch May 2, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawoudIO DawoudIO DawoudIO approved these changes

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
Code Smell php Pull requests that update Php code
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Replace "mustache/mustache" with a better-maintained templating library, like "twigphp/twig"
2 participants
@DAcodedBEAT @DawoudIO
0