8000 Add missing listOption use statement by respencer · Pull Request #6986 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing listOption use statement #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Add missing listOption use statement #6986

merged 1 commit into from
May 3, 2024

Conversation

respencer
Copy link
Contributor

Description & Issue number it closes

Found while confirming: #5675

Screenshots (if appropriate)

None.

How to test the changes?

See Cypress Recorder steps below.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Before the steps below cause the page to crash.

[03-May-2024 07:37:07 America/Detroit] PHP Fatal error:  Uncaught Error: Class "ListOption" not found in /var/www/html/GroupPropsFormEditor.php:169
Stack trace:
#0 {main}
  thrown in /var/www/html/GroupPropsFormEditor.php on line 169

After the changes the new fields are allowed to be added.

📋 Cypress Recorder Steps:

cy.visit('http://localhost/session/begin');
cy.xpath('//*[@id="UserBox"]').click();
cy.xpath('//*[@id="UserBox"]').type('admin');
cy.xpath('//*[@id="PasswordBox"]').type('changeme');
cy.xpath('//*[@id="remember"]').click();
cy.xpath('/html/body/div[1]/div/div[2]/form/div[3]/div[2]/button').click();
cy.url().should('contains', 'http://localhost/v2/dashboard');
cy.xpath('/html/body/div/aside/div/nav/ul/div[2]/a/p/span[1]').click();
cy.url().should('contains', 'http://localhost/GroupList.php');
cy.url().should('contains', 'http://localhost/GroupEditor.php');
cy.xpath('//*[@id="enableGroupProps"]').click();
cy.xpath('//*[@id="setgroupSpecificProperties"]').click();
cy.url().should('contains', 'http://localhost/GroupEditor.php');
cy.url().should('contains', 'http://localhost/GroupPropsFormEditor.php');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[2]/td/table/tbody/tr/td[2]/select').type('4');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[2]/td/table/tbody/tr/td[2]/select').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[2]/td/table/tbody/tr/td[3]/input').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[2]/td/table/tbody/tr/td[3]/input').type('Name');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[2]/td/table/tbody/tr/td[4]/input').type('Hebrew Name');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[2]/td/table/tbody/tr/td[5]/input').click();
cy.url().should('contains', 'http://localhost/GroupPropsFormEditor.php');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[2]/select').type('3');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[2]/select').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[3]/input').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[3]/input').type('Date');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[4]/input').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[4]/input').type('Hebrew Date');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[7]/td/table/tbody/tr/td[5]/input').click();
cy.url().should('contains', 'http://localhost/GroupPropsFormEditor.php');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[8]/td/table/tbody/tr/td[2]/select').type('12');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[8]/td/table/tbody/tr/td[2]/select').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[8]/td/table/tbody/tr/td[3]/input').click();
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[8]/td/table/tbody/tr/td[3]/input').type('Relation');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[8]/td/table/tbody/tr/td[4]/input').type('Relationship');
cy.xpath('/html/body/div/div[2]/section[2]/div/div/form/div/table/tbody/tr[8]/td/table/tbody/tr/td[5]/input').click();
cy.url().should('contains', 'http://localhost/GroupPropsFormEditor.php');

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer
Add missing reference
9cb7a4a 
Found while confirming: ChurchCRM#5675
@respencer respencer requested a review from a team as a code owner May 3, 2024 13:18
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 3, 2024 13:18
@DAcodedBEAT DAcodedBEAT merged commit 0ccb0e2 into ChurchCRM:master May 3, 2024
3 checks passed
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.8.0) milestone May 3, 2024
@DAcodedBEAT DAcodedBEAT added the php Pull requests that update Php code label May 3, 2024
@DAcodedBEAT DAcodedBEAT changed the title Add missing listOption Add missing listOption use statement May 3, 2024
@respencer respencer deleted the add-missing-listOption branch May 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DAcodedBEAT DAcodedBEAT DAcodedBEAT approved these changes

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
bug Feature: Groups php Pull requests that update Php code
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@respencer @DAcodedBEAT
0