8000 prevent deprecation warning in InputUtils by DAcodedBEAT · Pull Request #7054 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

prevent deprecation warning in InputUtils #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2024
Merged

prevent deprecation warning in InputUtils #7054

merged 1 commit into from
May 26, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

Description & Issue number it closes

Noticed that this is a possible code path if a code path was not developed correctly:

PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated

Added this to avoid this potential log-spam.

@DAcodedBEAT DAcodedBEAT added Code Smell php Pull requests that update Php code labels May 25, 2024
@DAcodedBEAT DAcodedBEAT self-assigned this May 25, 2024
@DAcodedBEAT DAcodedBEAT marked this pull request as ready for review May 25, 2024 23:05
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner May 25, 2024 23:05
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team May 25, 2024 23:05
@DAcodedBEAT DAcodedBEAT merged commit 7e0f8c0 into master May 26, 2024
6 checks passed
@DAcodedBEAT DAcodedBEAT deleted the avoid-inputfilter-deprecation-warning branch May 26, 2024 02:36
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.9.0) milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees

@DAcodedBEAT DAcodedBEAT

Labels
Code Smell php Pull requests that update Php code
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@DAcodedBEAT
0