8000 Propel developer experience improvement by DAcodedBEAT · Pull Request #7051 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Propel developer experience improvement #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2024

Conversation

DAcodedBEAT
Copy link
Contributor
@DAcodedBEAT DAcodedBEAT commented May 25, 2024

Description & Issue number it closes

Minor enhancements:

  • run propel ORM class generation after any composer autoload generation (typically composer install or composer update
  • moved propel ORM configuration within backend php application directory
  • moved propel scripts into composer.json, since it's unrelated to frontend code
  • normalized composer.json via https://github.com/ergebnis/composer-normalize
  • fixed discovered typo in cypress test

note: this prevents newcomers from having issues if they aren't aware of the code-gen aspect (like in #7039), as the code would automatically be re-generated on any composer autoload generation.

Screenshots (if appropriate)

N/A

How to test the changes?

app should work the same as it did previously

Type of change

  • ✨ Developer Experience Enhancement

@DAcodedBEAT DAcodedBEAT added Platform: Database Code Smell php Pull requests that update Php code labels May 25, 2024
@DAcodedBEAT DAcodedBEAT self-assigned this May 25, 2024
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner May 25, 2024 19:48
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team May 25, 2024 19:48
@DAcodedBEAT DAcodedBEAT force-pushed the propel-developer-experience-improvement branch 2 times, most recently from 334a740 to cf6841a Compare May 26, 2024 02:37
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.9.0) milestone May 26, 2024
@DAcodedBEAT DAcodedBEAT force-pushed the propel-developer-experience-improvement branch 2 times, most recently from 89a82c4 to 41a3d44 Compare May 27, 2024 02:13
@respencer respencer force-pushed the propel-developer-experience-improvement branch from 41a3d44 to fa1e8c1 Compare May 27, 2024 07:42
@DAcodedBEAT DAcodedBEAT merged commit 7320c6f into master May 27, 2024
6 checks passed
@DAcodedBEAT DAcodedBEAT deleted the propel-developer-experience-improvement branch May 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Smell php Pull requests that update Php code Platform: Database
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants
0