8000 Bug: Cannot delete some family information by bigtigerku · Pull Request #7126 · ChurchCRM/CRM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug: Cannot delete some family information #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2024
Merged

Bug: Cannot delete some family information #7126

merged 1 commit into from
Sep 1, 2024

Conversation

bigtigerku
Copy link
Contributor

Description & Issue number it closes

This bug doesn't allow us to delete WeddingDate, Email, Latitude and Longitude.

How to test the changes?

Add these information
Save
Try to delete them

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 1, 2024 00:41
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 1, 2024 00:41
@DAcodedBEAT
Copy link
Contributor

Nice find! Can you add/modify a cypress end-to-end test to account for this case?

@bigtigerku
Copy link
Contributor Author

Nice find! Can you add/modify a cypress end-to-end test to account for this case?

Done

@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 1, 2024
@DAcodedBEAT DAcodedBEAT merged commit 0c4db97 into ChurchCRM:master Sep 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DAcodedBEAT DAcodedBEAT DAcodedBEAT approved these changes

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
bug Feature: Users
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bigtigerku @DAcodedBEAT
0