8000 Some apis name need refactoring · Issue #5 · CiscoUcs/ucsc_apis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Some apis name need refactoring #5
Open
@tanmayx

Description

@tanmayx

ucsc apis: Latest code
python version: 2.7.12

Below APIs name need to be changed in parity with others -
user_add_role() --> should be user_role_add()
user_remove_role() --> should be user_role_remove()
user_add_locale() --> should be user_locale_add()
user_remove_locale() --> should be user_locale_remove()

Some more APIs to be refactored -
qos_policy_add() -> qos_policy_create()
qos_policy_remove() -> qos_policy_delete()
mac_pool_remove() -> mac_pool_delete()
lcp_vnic_delete() -> lcp_vnic_remove()
lcp_iscsi_vnic_delete() -> lcp_iscsi_vnic_remove()
ip_pool_remove() -> ip_pool_delete()
radius_provider_group_add_provider() -> radius_provider_group_provider_add()
radius_provider_group_modify_provider() -> radius_provider_group_provider_modify()
radius_provider_group_remove_provider() -> radius_provider_group_provider_remove()

Some APIs in tacacsplus.py module also needs refactoring.
ntp_server_create API name can be changed to ntp_server_add

The 'severity' param in syslog_local_console_enable API takes only 3 values ('emergencies', 'alerts' and 'critical'). But as per UI, we have 5 more values ('error', 'warning', 'notification', 'information', 'debug'). Setting one of these values through the API throws below error -

Traceback (most recent call last):
File "c:\python27\lib\site-packages\nose\case.py", line 197, in runTest
self.test(*self.arg)
File "C:\Tanmay\PythonSDK\pysdkframework\TestSuite_UcsCentral\Nosetests\admin\test_syslog.py", line 38, in test_syslog_local_console_enable

severity='error')
File "c:\python27\lib\site-packages\ucsc_apis-0.9.0.0-py2.7.egg\ucsc_apis\admin\syslog.py", line 52, in syslog_local_console_enable
mo.severity = severity
File "c:\python27\lib\site-packages\ucscsdk-0.9.0.0-py2.7.egg\ucscsdk\ucscmo.py", line 134, in setattr
self.__set_prop(name, value)
File "c:\python27\lib\site-packages\ucscsdk-0.9.0.0-py2.7.egg\ucscsdk\ucscmo.py", line 185, in __set_prop
value))
ValueError: Invalid Value Exception - [CommSyslogConsole]: Prop , Value.
-------------------- >> begin captured logging << --------------------
ucscentral: DEBUG: severity valid values are ['alerts', 'critical', 'emergencies']
--------------------- >> end captured logging << ---------------------_

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0