8000 pod lib lint is broken · Issue #12664 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pod lib lint is broken #12664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kstenerud opened this issue Oct 28, 2024 · 12 comments · Fixed by #12669
Closed

pod lib lint is broken #12664

kstenerud opened this issue Oct 28, 2024 · 12 comments · Fixed by #12669

Comments

@kstenerud
Copy link

Report

What did you do?

pod lib lint on a fresh, very basic framework project.

What did you expect to happen?

Successful linting

What happened instead?

It fails with various errors, such as:

  • //privateTarget Support Files/MyFramework/MyFramework-umbrella.h:13:9: error: double-quoted include "MyFramework.h" in framework header, expected angle-bracketed instead
  • Sandbox: rsync.samba(44452) deny(1) file-write-create /Users/karl.stenerud/Library/Developer/Xcode/DerivedData/App-gnevzkrtpocjzeduklkdbvflsxod/Build/Products/Release-iphonesimulator/App.app/Frameworks/MyFramework.framework/_CodeSignature (in target 'App' from project 'App')

CocoaPods Environment

Stack

   CocoaPods : 1.15.2
        Ruby : ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [arm64-darwin22]
    RubyGems : 3.2.33
        Host : macOS 14.7 (23H124)
       Xcode : 15.4 (15F31d)
         Git : git version 2.39.3 (Apple Git-146)
Ruby lib dir : /Users/karl.stenerud/.rbenv/versions/3.0.6/lib
Repositories : ariadnext-idcheckio-axt-podspecs - git - https://git-externe.rennes.ariadnext.com/idcheckio/axt-podspecs.git @ 2ebd182962d6b2812d1a82909d413b80b6b56867

               cocoapods - git - https://github.com/CocoaPods/Specs.git @ 0ad68fd861cfd5cc53d5e5061cf7f6faedfd637f

               trunk - CDN - https://cdn.cocoapods.org/

Installation Source

Executable Path: /Users/karl.stenerud/.rbenv/versions/3.0.6/bin/pod

Plugins

claide-plugins        : 0.9.2
cocoapods-deintegrate : 1.0.5
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.1
cocoapods-trunk       : 1.6.0
cocoapods-try         : 1.2.0

Project that demonstrates the issue

https://github.com/kstenerud/cocoapods-framework-issue
@Saimoness
Copy link

We’re encountering the same problem with double-quoted include "pb.h" in framework header, expected angle-bracketed instead warnings when using:

gem 'cocoapods', '~> 1.15'

I’ve attached a screenshot for reference. Despite troubleshooting and attempted modifying CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER, we haven’t been able to resolve this.
Any insights would be greatly appreciated. Thank you!

Screenshot 2024-10-28 at 19 21 45

@Chuckv01
8000
Copy link

I can confirm this issue is breaking CI on a number of apps. Targeting a previous version of CocoaPods does not appear to resolve the issue.

@m6vrm
Copy link
m6vrm commented Oct 28, 2024 •
edited
Loading

Pin xcodeproj to earlier version in Gemfile: gem 'xcodeproj', '1.25.1'
It was broken in 1.26.0: CocoaPods/Xcodeproj#990

Also, you can remove Gemfile.lock from .gitignore to avoid errors with updated dependencies in future.

@Saimoness
Copy link
Saimoness commented Oct 28, 2024 •
edited
Loading

Pin xcodeproj to earlier version in Gemfile: gem 'xcodeproj', '1.25.1' It was broken in 1.26.0: CocoaPods/Xcodeproj#990

Also, you can remove Gemfile.lock from .gitignore to avoid errors with updated dependencies in future.

Thanks, @m6vrm for pointing out the bug in gem xcodeproj 1.26.0. Pinning the xcodeproj gem to version 1.25.1 indeed resolves the issue. This should be the accepted answer.

This was referenced Oct 29, 2024
Closed
Closed
@xiushaomin
Copy link

when will resolve this issue?

@BestiOSDev
Copy link

when will resolve this issue?

use cocoapods 1.16.0

@kstenerud
Copy link
Author
kstenerud commented Oct 29, 2024 •
edited
Loading

1.16.0 fixes the headers issue, but the sandbox issue remains.

Repro case: https://github.com/kstenerud/cocoapods-framework-issue

Steps to reproduce:

pod lib lint

Output

$ pod lib lint

 -> MyFramework (1.0.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [iOS] xcodebuild:  note: Target dependency graph (3 targets)
    - NOTE  | [iOS] xcodebuild:  note: Signing static framework with --generate-pre-encrypt-hashes (in target 'Pods-App' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  error: Sandbox: rsync.samba(85833) deny(1) file-write-create /Users/karl.stenerud/Library/Developer/Xcode/DerivedData/App-eigfkkgvdgrbqzfdfjlovpbjzurq/Build/Products/Release-iphonesimulator/App.app/Frameworks/MyFramework.framework/_CodeSignature (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  error: Sandbox: rsync.samba(85834) deny(1) file-write-create /Users/karl.stenerud/Library/Developer/Xcode/DerivedData/App-eigfkkgvdgrbqzfdfjlovpbjzurq/Build/Products/Release-iphonesimulator/App.app/Frameworks/MyFramework.framework/.Info.plist.Pwo7uI (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  error: Sandbox: rsync.samba(85834) deny(1) file-write-create /Users/karl.stenerud/Library/Developer/Xcode/DerivedData/App-eigfkkgvdgrbqzfdfjlovpbjzurq/Build/Products/Release-iphonesimulator/App.app/Frameworks/MyFramework.framework/.MyFramework.6bX75E (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  rsync error: some files could not be transferred (code 23) at /AppleInternal/Library/BuildRoots/289ffcb4-455d-11ef-953d-e2437461156c/Library/Caches/com.apple.xbs/Sources/rsync/rsync/main.c(996) [sender=2.6.9]

[!] MyFramework did not pass validation, due to 1 error.
You can use the `--no-clean` option to inspect any issue.

Discussion

This error occurs because the App.xcworkspace created by cocoapods to validate the podspec has ENABLE_USER_SCRIPT_SANDBOXING set to YES:

Screenshot 2024-10-29 at 09 23 09

@hackiftekhar
Copy link

I'm also facing exactly same issue

@avelino-rodrigues
Copy link
avelino-rodrigues commented Oct 29, 2024 •
edited
Loading

Same issue here with ENABLE_USER_SCRIPT_SANDBOXING...

Adding this in podspec works as a workaround for this issue

s.xcconfig = {
        'ENABLE_USER_SCRIPT_SANDBOXING' => 'NO',
    }

@hackiftekhar
Copy link

Thanks @avelino-rodrigues This worked for me as a workaround.

@bamx23 bamx23 mentioned this issue Oct 29, 2024
Merged
@paulb777 paulb777 mentioned this issue Oct 29, 2024
Merged
@amorde amorde mentioned this issue Oct 29, 2024
Merged
@amorde
Copy link
Member
amorde commented Oct 29, 2024

@kstenerud thank you for the report and the example project with the easy repro. I've put up a PR and will get out a patch release as soon as I can.

@khoogheem
Copy link

did this go to home-brew not seeing this version available

@BrewTestBot BrewTestBot mentioned this issue Oct 29, 2024
Merged
@ynyyn ynyyn mentioned this issue Oct 30, 2024
Merged
@dfed dfed mentioned this issue Oct 30, 2024
Merged
@amorde amorde closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix validation failure from new xcodeproj settings CocoaPods/CocoaPods
10 participants
@kstenerud @khoogheem @Chuckv01 @amorde @hackiftekhar @BestiOSDev @xiushaomin @avelino-rodrigues @Saimoness @m6vrm
0