10000 Test Specs' schemes should include the test scheme · Issue #6765 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test Specs' schemes should include the test scheme 8000 #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
segiddins opened this issue May 31, 2017 · 3 comments · Fixed by #6842
Closed
1 task done

Test Specs' schemes should include the test scheme #6765

segiddins opened this issue May 31, 2017 · 3 comments · Fixed by #6842
Labels
d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Milestone
Test Specs

Comments

@segiddins
Copy link
Member

Report

What did you do?

Ran pod lib lint --no-clean

What did you expect to happen?

The scheme for my pod with a test specification should have included the test schemes under the list of tests in the scheme editor

What happened instead?

It did not, that list of tests was empty.

CocoaPods Environment

Stack

   CocoaPods : 1.2.1
        Ruby : ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16]
    RubyGems : 2.6.12
        Host : Mac OS X 10.12.4 (16E195)
       Xcode : 8.3 (8W132p)
         Git : git version 2.13.0
Ruby lib dir : /Users/segiddins/.rubies/2.4.1/lib
Repositories : artsy - https://github.com/artsy/Specs.git @ 91c57cfdfaedfa39aacf7fae74ce5339baba0e7c
               buithuyen - https://github.com/buithuyen/Specs.git @ a6e6fe0cef7644fe55139842bf8529013f9821dc
               eyeem - https://github.com/eyeem/CocoaPods-Specs.git @ 1749fee08c2524d992af4bf368566449ae7668b1
               master - https://github.com/CocoaPods/Specs.git @ 2875e9fb983932700917632035be09f6200903ba
               unityappstudio - https://github.com/unityappstudio/Specs.git @ 4c5d9046d47906df7b3bafa6641cb4e752f057a7

Installation Source

Executable Path: /Users/segiddins/Development/Rainforest/CocoaPods/bin/pod

Plugins

claide-plugins         : 0.9.0
cocoapods-deintegrate  : 1.0.1
cocoapods-dependencies : 1.0.0.beta.1
cocoapods-plugins      : 1.0.0
cocoapods-search       : 1.0.0
cocoapods-stats        : 1.0.0
cocoapods-trunk        : 1.2.0
cocoapods-try          : 1.1.0
cocoapods_debug        : 0.1.0

Podfile

install! 'cocoapods',
  integrate_targets: false,
  share_schemes_for_development_pods: true

target 'Test' do
  platform :osx, '10.10'
  use_frameworks!
  pod 'FooBar', path: '.'
end

Project that demonstrates the issue

https://github.com/segiddins/CocoaPods-Test-Spec-Test
@endocrimes endocrimes added this to the Test Specs milestone May 31, 2017
@endocrimes endocrimes added d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels May 31, 2017
@dnkoutso
Copy link
Contributor

I believe this is already done. The podfile is missing pod 'FooBar/Tests' and it would automatically share the xcscheme.

@segiddins
Copy link
Member Author

Ideally, the test scheme would appear under the framework schemes testable list. But not a huge deal

@dnkoutso
Copy link
Contributor

I think to achieve adding CMD+U support to the framework scheme itself we need to update https://github.com/CocoaPods/Xcodeproj/blob/master/lib/xcodeproj/project.rb#L800-L820 to provide a block to edit xcschemes as they get recreated.

Otherwise we would have to re-save (which might slow things down) after recreate_user_schemes returns.

@segiddins segiddins added t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it and removed t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels May 31, 2017
@dnkoutso dnkoutso mentioned this issue Jul 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d1:easy An easy ticket that is a good start for first-time contributors s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Projects
None yet
Milestone
Test Specs
Development

Successfully merging a pull request may close this issue.

Include test schemes within library schemes dnkoutso/CocoaPods
3 participants
@dnkoutso @endocrimes @segiddins
0