8000 pod install --repo-update doesn't update private specs · Issue #8421 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pod install --repo-update doesn't update private specs #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grantmike opened this issue Jan 14, 2019 · 5 comments
Closed

pod install --repo-update doesn't update private specs #8421

grantmike opened this issue Jan 14, 2019 · 5 comments
Labels
help wanted Help from new or existing contributors would be greatly appreciated! t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Milestone
1.7.0

Comments

@grantmike
Copy link
grantmike commented Jan 14, 2019 •
edited
Loading

Report

What did you do?

Run pod install --repo-update

What did you expect to happen?

All specs updated, including private specs

Compare the output of pod repo update:

Updating spec repo `PrivateRepo`
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/privateRepo fetch origin --progress
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/privateRepo rev-parse --abbrev-ref HEAD
  master
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/privateRepo reset --hard origin/master
  HEAD is now at 5139c05 "Commit message"
Updating spec repo `master`
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/master fetch origin --progress
  remote: Enumerating objects: 2691, done.        
  remote: Counting objects: 100% (2691/2691), done.        
  remote: Compressing objects: 100% (86/86), done.        
  remote: Total 5878 (delta 2628), reused 2638 (delta 2604), pack-reused 3187        
  Receiving objects: 100% (5878/5878), 618.97 KiB | 1.27 MiB/s, done.
  Resolving deltas: 100% (4029/4029), completed with 1045 local objects.
  From https://github.com/CocoaPods/Specs
     50a8cfbc31f..a4cd0ea2557  master     -> origin/master
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/master rev-parse --abbrev-ref HEAD
  master
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/master reset --hard origin/master
  HEAD is now at a4cd0ea2557 [Add] ChocolatePlatform-SDK-Googleadmob 1.1.0

What happened instead?

Only public specs updated

Updating local specs repositories
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/master fetch origin --progress
  remote: Enumerating objects: 15, done.        
  remote: Counting objects: 100% (15/15), done.        
  remote: Compressing objects: 100% (9/9), done.        
  remote: Total 9 (delta 6), reused 0 (delta 0), pack-reused 0        
  From https://github.com/CocoaPods/Specs
     a4cd0ea2557..73981646581  master     -> origin/master
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/master rev-parse --abbrev-ref HEAD
  master
  $ /usr/bin/git -C /Users/user/.cocoapods/repos/master reset --hard origin/master
  HEAD is now at 73981646581 [Add] ChocolatePlatform-SDK-Inmobi 2.1.0

CocoaPods Environment

Stack

   CocoaPods : 1.5.3
        Ruby : ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin17]
    RubyGems : 2.6.11
        Host : Mac OS X 10.13.6 (17G65)
       Xcode : 10.1 (10B61)
         Git : git version 2.17.2 (Apple Git-113)
Ruby lib dir : /Users/user/.rbenv/versions/2.4.1/lib
Repositories : privateRepo - https://github.com/privateRepo/InternalCocoapodSpecs.git @ 5139c05766ed6c224b077b987bdc13fb919b9b13
               master - https://github.com/CocoaPods/Specs.git @ 73981646581c028ce33cf22423da2bd17c5abea3

Installation Source

Executable Path: /Users/user/Developer/project/bin/ruby/2.4.0/bin/pod

Plugins

cocoapods-deintegrate : 1.0.2
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.3.0
cocoapods-try         : 1.1.0

Podfile

$PRIVATE_SOURCE = 'https://github.com/privateRepo/InternalCocoapodSpecs.git'

platform :ios, '11.0'

use_frameworks!

def shared_pods
  pod 'Alamofire', '4.8.0'
  pod 'Crashlytics', '3.10.9'
  pod 'Cocoapod', '0.3.0', :source => $PRIVATE_SOURCE
end

target 'MyAppShared' do
  shared_pods
end

target 'MyApp' do
  shared_pods

  FIREBASE_VERSION = '5.14.0'

  pod 'Adjust', '4.15.0'
  pod 'BulletinBoard', '2.0.2', :source => $PRIVATE_SOURCE
  pod 'Charts', '3.2.1'

  target 'MyAppTests' do
    inherit! :search_paths

    test_pods
  end
end

Project that demonstrates the issue

N/A
@segiddins
Copy link
Member

Ah, we might not be updating sources that are only specified at the per-pod level...

@segiddins segiddins added the t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! label Jan 14, 2019
@dnkoutso dnkoutso added the help wanted Help from new or existing contributors would be greatly appreciated! label Jan 17, 2019
amorde added a commit that referenced this issue Jan 24, 2019
@amorde
Ensure sources specified with the :source option are always updated…
e345d89 
… if `--repo-update` is specified

Closes #8421
@amorde amorde mentioned this issue Jan 24, 2019
Merged
@dnkoutso dnkoutso added this to the 1.7.0 milestone Jan 24, 2019
@amorde
Copy link
Member
amorde commented Jan 24, 2019

Thanks for the report 👍 this will be fixed in 1.7.0

@marchy
Copy link
marchy commented Mar 27, 2019

What's the workaround until then?

@grantmike
Copy link
Author

pod repo update
pod install

@marchy
Copy link
marchy commented Mar 27, 2019

Thanks @mgrant34. Perhaps we are seeing a different issue when using the pod '{pod name}', git: {Git repo URI} branch: 'master'` pod definition, which didn't seem to pull down the new commits on the branch.

A manual pod uninstall (ie: comment out line above) and re-install seemed to do the trick.

@denisPoifol denisPoifol mentioned this issue May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Help from new or existing contributors would be greatly appreciated! t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
5 participants
@dnkoutso @marchy @segiddins @amorde @grantmike
0