8000 Feature request - Support for CocoaPods registries · Issue #9690 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature request - Support for CocoaPods registries #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
eyalbe4 opened this issue Apr 5, 2020 · 17 comments
Closed
1 task done

Feature request - Support for CocoaPods registries #9690

eyalbe4 opened this issue Apr 5, 2020 · 17 comments
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it

Comments

@eyalbe4
Copy link
eyalbe4 commented Apr 5, 2020

JFrog Artifactory supports managing CocoaPods packages, through its CocoaPods Repositories. Since CocoaPods does not support Artifactory natively, the cocoapods-art gem is currently used for this integration. Since this is an external plugin, it can break, following changes implemented in Cocoapods.

We suggest adding native Artifactory support to CocoaPods, so that it can seamlessly work with Artifactory CocoaPods Repositories, like any other repository. 

We are willing to contribute this functionality through a pull request.
@dnkoutso
Copy link
Contributor
dnkoutso commented Apr 5, 2020 •
edited
Loading

what is an example of "breakage"? We tend to ensure we follow semver guidelines and not ship breaking changes.

@eyalbe4
Copy link
Author
eyalbe4 commented Apr 16, 2020

@dnkoutso,
Actually, the functionality we are proposing should allow CocoaPods to work with any CocoaPods registry, not just Artifactory, for the benefit of the CocoaPods community.
Once we have a working solution, we would like to share it with you and get your feedback for it.

@eyalbe4
Copy link
Author
eyalbe4 commented Apr 23, 2020

@dnkoutso,

The current title of this issue is a bit misleading, because we're actually not proposing to support Artifactory specifically. We think it makes more sense for CocoaPods to support any CocoaPods registry vendor. This would allow others to build their own CocoaPods proxies, and would greatly benefit the CocoaPods community. I'm therefore changing the title of this issue to "Feature request - Support for CocoaPods registries".

We've started looking into implementing this and hope we can get your feedback for a pull request we'll submit. We'd really appreciate any feedback, questions or requests you may already have for this initiative,  
Please let us know what you think.

@eyalbe4 eyalbe4 changed the title Feature request - Support for JFrog Artifactory Feature request - Support for CocoaPods registries Apr 23, 2020
@pschneider
Copy link

While in general this is definitely a good Idea to better support tools like Artifactory for proxying available libraries and making local builds faster and also reliable (in case of unavailable master repo, unpublished libraries) I think it doesn't really make sense to do that for the old style repository anymore. This is slow, takes a lot of space locally and in the end the CDN is/will be the preferred way (as far as I understood).

Therefor it should rather be possible to enable this for CocoaPods CDN which is as well not supported by Artifactory as of now: https://www.jfrog.com/jira/browse/RTFACT-20455

@eyalbe4
Copy link
Author
eyalbe4 commented May 5, 2020

Thanks for you comment and suggestion @pschneider!
We're currently looking into this option.

@dnkoutso
Copy link
Contributor

hey @eyalbe4 and others! Apologies for the long delay here. Past month I wasnt able to spend time on CocoaPods...

I think a proposal would make sense here in either direction and I would be glad to review PRs and the proposal itself to support it first-class within CocoaPods.

@dnkoutso dnkoutso added t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase labels Jun 21, 2020
@eyalbe4
Copy link
Author
eyalbe4 commented Jun 21, 2020

Hi @dnkoutso - thanks for your feedback!
I suggest we start with the old style solution, and put in a place a good working solution. Once done, we can look into the CDN option. Let us reallocate some time for this and start working on a PR.

@dnkoutso
Copy link
Contributor

sounds good!

This was referenced Aug 2, 2020
Closed
Closed
@eyalbe4
Copy link
Author
eyalbe4 commented Aug 2, 2020

@dnkoutso,
@yahavi created the above two PRs, which add support for CocoaPods registries.
Thanks!

@endocrimes
Copy link
Member

@eyalbe4 Is there a specification of the expected behavior for these registries? - I'd be a bit worried about merging in support for this without the expectations being documented

@eyalbe4
Copy link
Author
eyalbe4 commented Aug 3, 2020

@endocrimes,

Sure, I completely agree.

@yahavi added the usage details for the new functionality in the description of #9959 but please let us know where you would like us to document the specification. Also, if there's a preferred format or convention for the documenting the specification, please let us know and we'll make sure to follow it.

Thanks

@dnkoutso
Copy link
Contributor
dnkoutso commented Aug 3, 2020

@eyalbe4 an RFC write up can be very helpful. Some examples:

#8191
#8253 and
#8753

@dnkoutso
Copy link
Contributor

Any updates here? Would love this for 1.11.0 release.

@eyalbe4
Copy link
Author
eyalbe4 commented Aug 12, 2020

@dnkoutso,
Thanks for following up on this! We're also looking forward to making this happen.
Give us just a few more days to create the RFC.

@yahavi yahavi mentioned this issue Aug 20, 2020
Open
@yahavi
Copy link
yahavi commented Aug 20, 2020

@endocrimes @dnkoutso
We created a RFC for this feature: #9994
Thanks.

@dnkoutso dnkoutso added this to the 1.11.0 milestone Sep 7, 2020
@dnkoutso
Copy link
Contributor
dnkoutso commented Oct 2, 2020

Going to close this in favor of #9994! I do not think a separate issue adds anything more than the RFC.

@dnkoutso dnkoutso closed this as completed Oct 2, 2020
@dnkoutso dnkoutso removed this from the 1.11.0 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for CocoaPods registries yahavi/Core
Support for CocoaPods registries yahavi/CocoaPods
5 participants
@dnkoutso @pschneider @endocrimes @eyalbe4 @yahavi
0