Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
8000
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 18 commits
- 44 files changed
- 4 contributors
Commits on Aug 16, 2024
-
Add a --fast-deps option to
comfy install/reinstallthat enables ne……w faster/unified/uv-based dependency install (#141) * added uv script * --fast-deps option now works with installing comfyui core and comfyui-manager * `comfy node install --fast-deps` is now supported * `--fast-deps` installs of core/nodes now auto-detect gpu if `torch` is already installed * added section on developing comfy-cli and ComfyUI-Manager together * clean up specification of --fast-deps option * fix python 3.9 incompatible type hint syntax * picked lint * post rebase cleanup * make `DependencyCompiler` more flexible/testable * fix routine for finding custom node dirs * remove awkward `fastInstallComfyDeps` shim function * mark `staticmethod`s with UpperCamelCase names * cleanup `DependencyCompiler.InstallBuildDeps` * started adding tests for code in `uv.py` module * test_uv now runs, dies on mock extension vs extension dependency conflict * `uv` subprocess calls now print cmd/output on error - output is currently unsatisfactory in the case of a dependency conflict - doesn't print the names of conflicting top-level packages. The uv maintainers have expressed interest in fixing this: astral-sh/uv#1854 * add parsing of `uv compile` conflict error * add `resolve_strategy="ask"` option to `DependencyCompiler.Compile` - will manually prompt user for resolution in case of extension-vs-extension dependency conflict, using `ui.prompt_select` * basic implementation of ext-vs-ext conflict resolution via manual user input now functional - needs better output * improved feedback/UX of manual dependency conflict resolution * fixup user input for conflict resolution; fixup test-uv paths * `test_compile` in `test_uv` now works/runs correctly via pytest - still needs an actual assert at the end * added `assert` to `test_compile`. Might still be a bit fragile * made `test_compile` more robust * small type hint fix * mark old py dep install funcs with `pip_` prefix * in `uv.py`, make func/methods `snake_case`, static methods `Snake_Case` * ci test fix * disable nuisance lint rule (W0707)
-
Commits on Aug 20, 2024
-
added support for ruff linting and autoformatting (#149)
* added ruff and cleaned up `pyproject.toml` * remove unneeded project config files * `line-length=150` was too aggressive, change back to `120` * renamed `pylint.yml` -> `ruff_check.yml` in github actions * implement `ruff_check` github action * in `pre-commit` config, refactor all uses of `pylint` -> `ruff` * fix ruff linting command in ruff GA * add `pre-commit` to dev dependencies
-
Initial apply of ruff formatting (#157)
* initial apply of ruff lint/format via `pre-commit run --all-files` * fixed all initial non-autofixable complaints of new linter `ruff check`
-
-
Commits on Aug 21, 2024
Commits on Aug 23, 2024
-
-
Add builder for standalone python for comfy (#158)
* remove unneeded pylint config cruft * added utils to grab pre-built distros from the python-build-standalone project * added `StandalonePython` class * added type hinting to `standalone.py` and related * allow specification of python executable in `DependencyCompiler` * added `install_*` methods to `StandalonePython` * replaced `tqdm.wrapattr` with `rich.progress.wrap_file` as per review comment * `StandalonePython`: build precache based on existing comfy install * added `standalone` cli command * fix `test_compile` unittest * linted and formatted
Commits on Aug 24, 2024
-
Fixed: MAC_M_SERIES enum not found (#161)
* Fixed: Enum look up error. * removed `str` from `Union[GPU_OPTION, str, None]` typing in a bunch of places --------- Co-authored-by: telamonian <telamonian@users.noreply.github.com>
-
Commits on Aug 27, 2024
-
Add
.rehydrate_comfy_depsmethod toStandalonePython(#162)* add progress bar to tarfile creation in `StandalonePython` * add `extraSpecs` parameter to `DependencyCompiler` constructor * make `extraSpecs` parameter actually function * `StandalonePython.to_tarball`: better progress bar for writing tarball * simplify methods of `StandalonePython` into single `.dehydrate_comfy_deps` * add methods to `DependencyCompiler` to install from downloaded artifacts * fix pathing in tarball creation * in `StandalonePython`, add `.rehydrate_comfy_deps` method * add `--rehydrate` option to `standalone` command * fix `--rehydrate` option * improve wheel install triggered by `--rehydrate` option
-
-
-
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.36...v1.1.0