10000 proposal: add `pins` argument to `Venv` to allow specifying version pins · Issue #197 · DataDog/riot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

proposal: add pins argument to Venv to allow specifying version pins #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you 8338 agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
P403n1x87 opened this issue Jan 4, 2023 · 0 comments
Open

proposal: add pins argument to Venv to allow specifying version pins #197

P403n1x87 opened this issue Jan 4, 2023 · 0 comments

Comments

@P403n1x87
Copy link
Contributor

By design, the virtual env layering of riot is such that child virtual envs override parent ones. This means that declaring a pin as a dependency in the pkgs argument of a parent virtual env won't actually pin the dependency if this is installed in a child virtual env. To allow for adding pins to a parent virtual env so that they could be shared by the children, we could introduce the pins argument, which bubbles up all the pins up to the leaf virtual env, thus ensuring that the pin constraints are enforced.

Note that we still wouldn't have any compatibility checks even with this change.
@P403n1x87 P403n1x87 changed the title Add pins argument to Venv to allow specifying version pins proposal: add pins argument to Venv to allow specifying version pins Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@P403n1x87
0