Progress #299

modz4567 · 2024-04-28T17:01:07Z

Hi I was wondering if you were going to add to add the progress of showing the files and folders being added when the iso is being created please

LTRData · 2024-04-28T19:34:34Z

You mean the ISOCreate command line tool? I agree that would be useful. I will consider it next time I do something with the command line tools.

modz4567 · 2024-04-29T06:06:01Z

I have updated it myself should I create a push also I'm trying to look for in the code where to increase rhe speed of creating a iso image

LTRData · 2024-04-29T07:27:36Z

If you create a pull request in my fork at https://github.com/LTRData/DiscUtils I can take a look and merge it when it looks okay!

Also, my fork has a lot of performance improvements in general, so it is a better starting point if you want to make it faster. I think there could potentially be many more ways performance could be improved for ISO builder if we look deeper into it.

modz4567 · 2024-04-29T08:11:20Z

Well basically when adding files to the iso it takes some time maybe 4mins to create a 9gb iso

modz2014 · 2024-04-29T12:01:23Z

example here @LTRData

public event ProgressHandler ProgressChanged;

private void UpdateProgress(int currentProgress, int totalItems)
{
    this.ProgressChanged?.Invoke(currentProgress, totalItems);
}
public BuildFileInfo AddFile(string name, byte[] content)
{
    string[] array = name.Split(new char[1] { '\\' }, StringSplitOptions.RemoveEmptyEntries);
    BuildDirectoryInfo directory = GetDirectory(array, array.Length - 1, createMissing: true);
    if (directory.TryGetMember(array[array.Length - 1], out var _))
    {
        throw new IOException("File already exists");
    }

    BuildFileInfo buildFileInfo = new BuildFileInfo(array[array.Length - 1], directory, content);
    _files.Add(buildFileInfo);
    directory.Add(buildFileInfo);
    UpdateProgress(_files.Count, _files.Count + _dirs.Count);
    return buildFileInfo;
}
 public BuildFileInfo AddFile(string name, string sourcePath)
 {
     string[] array = name.Split(new char[1] { '\\' }, StringSplitOptions.RemoveEmptyEntries);
     BuildDirectoryInfo directory = GetDirectory(array, array.Length - 1, createMissing: true);
     if (directory.TryGetMember(array[array.Length - 1], out var _))
     {
         throw new IOException("File already exists");
     }

     BuildFileInfo buildFileInfo = new BuildFileInfo(array[array.Length - 1], directory, sourcePath);
     _files.Add(buildFileInfo);
     directory.Add(buildFileInfo);
     UpdateProgress(_files.Count, _files.Count + _dirs.Count);
     return buildFileInfo;
 }
public BuildFileInfo AddFile(string name, Stream source)
{
    if (!source.CanSeek)
    {
        throw new ArgumentException("source doesn't support seeking", "source");
    }

    string[] array = name.Split(new char[1] { '\\' }, StringSplitOptions.RemoveEmptyEntries);
    BuildDirectoryInfo directory = GetDirectory(array, array.Length - 1, createMissing: true);
    if (directory.TryGetMember(array[array.Length - 1], out var _))
    {
        throw new IOException("File already exists");
    }

    BuildFileInfo buildFileInfo = new BuildFileInfo(array[array.Length - 1], directory, source);
    _files.Add(buildFileInfo);
    directory.Add(buildFileInfo);
    UpdateProgress(_files.Count, _files.Count + _dirs.Count);
    return buildFileInfo;
}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Progress #299

Progress #299

Progress #299

Progress #299

Comments