8000 Add support for tracking drying of spools by SConaway · Pull Request #711 · Donkie/Spoolman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for tracking drying of spools #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add support for tracking drying of spools #711

wants to merge 5 commits into from
+278 −31

Conversation

SConaway
Copy link
@SConaway SConaway commented Jun 12, 2025 •
edited
Loading

Adding support for tracking drying status of filament spools.

Implemented so far:

  • server changes
    • database
    • migration
    • API support
    • API docs (can't get them to generate on my machine, pdm was giving me grief and I can't get them to generate with the REPL.)
  • UI changes
    • Spool Show page
      • Displays dried and last_dried fields with appropriate labels
      • modal to add drying
    • Spool List page
      • Can display last_dried field with appropriate labels & sort by it
      • modal to add drying
    • Spool Edit page -- nothing is changed here, as I'm not sure what the best UI would look like / how it would work

@Donkie
Copy link
Owner
Donkie commented Jun 16, 2025

I appreciate you working on improving Spoolman, but I gotta ask, why can't this be solved using the already existing "extra fields" feature?

@SConaway
Copy link
Author

It could, but then the dry button wouldn't be implemented in the list UI — right now, I have last_dried as an extra field of my own, but it's clunky to use as I have to edit the spool as opposed to clicking the dry icon from the list view.

@Donkie
Copy link
Owner
Donkie commented Jun 16, 2025

I understand, but this is a somewhat niche use-case for doing something relatively obtrusive as adding a button in the spool list page. Most people won't care about it.

Perhaps it can be hidden behind a setting?

@SConaway
Copy link
Author

That's totally fair! I'm open to whatever you think best -- just let me know, and I can try to get the code changed (am not completely familiar with your code!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SConaway @Donkie
0