8000 Renderer setters don't work until after initialize promise resolves · Issue #102 · GoogleChrome/omnitone · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Renderer setters don't work until after initialize promise resolves #102
Open
@brianchirls

Description

@brianchirls

All of the setter methods on the renderers (e.g. setChannelMap, setRotationMatrix3) do nothing if they are called before the initialize promise resolves. There is no warning or error, and this behavior is not documented.

There isn't really any reason why these methods can't operate immediately, since they depend on objects created in _buildAudioGraph, which is run in the constructor, not in initialize. (Initialization only loads the HRIRs.)

This issue manifests, for example, as a bug in Resonance Audio Web SDK where the rotation matrix should be set immediately by an option to the constructor, but it does not take effect because the setRotationMatrix3 call on the Omnitone renderer does nothing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0