-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix/skip tests for MIPI cam #10592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maloel
merged 13 commits into
IntelRealSense:D4XX_MIPI
from
SamerKhshiboun:d457_unit_tests_fix
Jun 16, 2022
Merged
fix/skip tests for MIPI cam #10592
maloel
merged 13 commits into
IntelRealSense:D4XX_MIPI
from
SamerKhshiboun:d457_unit_tests_fix
Jun 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Added option "!" to tests infrastructure to skip/ignore specific devices in the unit test run
- e.g. #test:device each(D400*) !D457
- Fix / Skip specific tests for the D4XX MIPI CAM in order to pass LibCI
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
8000
maloel
reviewed
Jun 14, 2022
8000
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 14, 2022
maloel
reviewed
Jun 15, 2022
unit-tests/py/rspy/devices.py
Outdated
ignored_list_as_str = " ".join(ignored_products) | ||
if name not in ignored_list_as_str: | ||
for device in _device_by_sn.values(): | ||
if device.name.find( name ) >= 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
device.name
may be Null
. Please check it (as the original code does).
maloel
approved these changes
Jun 15, 2022
…un/librealsense into d457_unit_tests_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.