8000 Restore tab in same place it was closed after `action.reopenTab` · Issue #103 · Jelmerro/Vieb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restore tab in same place it was closed after action.reopenTab #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
InconsolableCellist opened this issue Dec 14, 2020 · 4 comments
Closed

Restore tab in same place it was closed after action.reopenTab #103

InconsolableCellist opened this issue Dec 14, 2020 · 4 comments
Assignees
@Jelmerro
Labels
enhancement New feature or request gui Graphical user interface related issues

Comments

@InconsolableCellist
Copy link
Contributor

Steps to reproduce:

  1. Open two tabs
  2. Go to tab 1
  3. Hit 'd' to execute "action.closeTab"
  4. Hit 'u' to execute "action.reopenTab"

Observed behavior:
Restored tab goes into position 2, not position 1

Expected Behavior:
Restored tab goes into position 1, which is where it was when it was closed

This can be repeated for tabs in any position

The expected behavior is like that in at least Pentadactyl and Vimperator
@InconsolableCellist InconsolableCellist added the bug Something isn't working label Dec 14, 2020
@Jelmerro Jelmerro added enhancement New feature or request question Further information is requested and removed bug Something isn't working labels Dec 15, 2020
@Jelmerro
Copy link
Owner

I don't see how this is a bug. At most this is unexpected, but restoring tabs works and currently always opens to the right of the current one. Regardless of what you want to call it, we could add a setting to determine on which side restored tabs should open, if that is more in line with what you expect. Is that a workable solution? Or do you propose something else?

@InconsolableCellist
Copy link
Contributor Author

It's not really about left or right, it's about its previous location. My versions of Firefox and Chromium both seem to do this, so I figured it's a bug.

If you have 8 tabs, and close tab #3, then no matter what tab you're on when you restore it, it'll return to the #3 position.

@Jelmerro Jelmerro added gui Graphical user interface related issues help wanted Help wanted with this issue, so PRs are encouraged! and removed question Further information is requested labels Dec 15, 2020
@Jelmerro
Copy link
Owner

I seems that we both expect different positions when restoring tabs. I have always found it odd that I couldn't control the tab position when restoring, and that it would remember that kind of info even when tabs are closed. For me that was more of an annoyance than a feature. So in Vieb I made it consistently open and reopen tabs to the right of the current one.

As such, I won't work on this myself in the near future, but feel free to implement a setting for the tab restore position via a PR, with the possible values: "left", "previous" and "right" (default).

@Jelmerro Jelmerro self-assigned this Feb 24, 2021
@Jelmerro Jelmerro removed the help wanted Help wanted with this issue, so PRs are encouraged! label Feb 24, 2021
@Jelmerro
Copy link
Owner

Implemented in 6ac7db9, try running and building from the V4 branch to check it out, or wait for the next stable (first week of march hopefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jelmerro Jelmerro

Labels
enhancement New feature or request gui Graphical user interface related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jelmerro @InconsolableCellist
0