8000 Support naming checkpoint to load after SCR_Init but before SCR_Start_restart · Issue #475 · LLNL/scr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support naming checkpoint to load after SCR_Init but before SCR_Start_restart #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adammoody opened this issue Feb 9, 2022 · 0 comments · Fixed by #480
Closed

Support naming checkpoint to load after SCR_Init but before SCR_Start_restart #475

adammoody opened this issue Feb 9, 2022 · 0 comments · Fixed by #480

Comments

@adammoody
Copy link
Contributor
adammoody commented Feb 9, 2022 •
edited
Loading

Some applications would prefer to call SCR_Init before they have identified the name of the checkpoint that SCR should load. Those applications cannot set SCR_CURRENT before calling SCR_Init.

Rather than executing the fetch during SCR_Init, we could delay it until SCR_Have_restart. This would enable users to specify the checkpoint name after SCR_Init but still before SCR_Have_restart. SCR_Init could still detect, rebuild, and optionally flush any cached checkpoints.

For naming the checkpoint, there are several options to look at:

  • Stick with SCR_Config("SCR_CURRENT=foo"). In that case, setting SCR_CURRENT is sort of special cased, since basically all other settings must still be set before SCR_Init.
  • Use the SCR_Current(const char* name) call. This call is used in apps that restart from an SCR checkpoint but do so without using SCR's restart API. It provides a way for the application to tell SCR which checkpoint was loaded so that SCR can initialize its state to match. We could extend this API to allow a user to specify a checkpoint name before SCR_Have_restart.
  • Define the name parameter in SCR_Have_restart to be an input/output parameter. Right now, the name argument is output only. SCR fills it in with the name of the checkpoint that it loaded. We could change it to be an input/output parameter allowing the user to request a particular name as part of the SCR_Have_restart call. We'd have some backwards compatibility items to think about, though, since users don't currently set that parameter before calling SCR_Have_restart.
  • Come up with a new API call.

Related issues:
@adammoody adammoody changed the title Support naming checkpoint after SCR_Init but before SCR_Start_restart Support naming checkpoint to load after SCR_Init but before SCR_Start_restart Feb 9, 2022
@adammoody adammoody mentioned this issue Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development < 3399 /div>

Successfully merging a pull request may close this issue.

move fetch from init to have_restart LLNL/scr
1 participant
@adammoody
0