8000 Remove `network` query param from queries that specify the resource ID · Issue #1812 · LiskHQ/lisk-mobile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove network query param from queries that specify the resource ID #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1368
clemente-xyz opened this issue May 8, 2023 · 0 comments · Fixed by #1813
Closed
Tracked by #1368

Remove network query param from queries that specify the resource ID #1812

clemente-xyz opened this issue May 8, 2023 · 0 comments · Fixed by #1813
Assignees
@clemente-xyz
Labels
type: bug
Milestone
Sprint 63

Comments

@clemente-xyz
Copy link
Member

Expected behavior

Since resources are unique on each network, when specifying their IDs on endpoint calls, is not necessary to include the network filter.

Actual behavior

Some queries are still specifying the network when the ID is also specified.

This generates some issues since the devnet deployment is using the betanet genesis blocks and has chainIDs/tokenIDs beginning with 02.

Which version(s) does this affect? (Environment, OS, etc...)

All.
@clemente-xyz clemente-xyz added this to the Sprint 62 milestone May 8, 2023
@clemente-xyz clemente-xyz self-assigned this May 8, 2023
@clemente-xyz clemente-xyz mentioned this issue May 8, 2023
Merged
3 tasks
@clemente-xyz clemente-xyz moved this from Backlog to Pending Review in Lisk Mobile Version 3.0.0 May 8, 2023
@github-project-automation github-project-automation bot moved this from Pending Review to Done in Lisk Mobile Version 3.0.0 May 8, 2023
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 62, Sprint 63 May 8, 2023
@sridharmeganathan sridharmeganathan mentioned this issue May 9, 2023
Closed
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemente-xyz clemente-xyz

Labels
type: bug
Projects
No open projects
Lisk Mobile Version 3.0.0
Status: Done
Milestone
Sprint 63
Development

Successfully merging a pull request may close this issue.

Remove network query param from queries that specify the resource ID LiskHQ/lisk-mobile
3 participants
@ManuGowda @clemente-xyz @sridharmeganathan
0