8000 Wallet Connect integration accepts any namespaces · Issue #1922 · LiskHQ/lisk-mobile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Wallet Connect integration accepts any namespaces #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1368
clemente-xyz opened this issue Jul 14, 2023 · 0 comments
Closed
Tracked by #1368

Wallet Connect integration accepts any namespaces #1922

clemente-xyz opened this issue Jul 14, 2023 · 0 comments
Assignees
@clemente-xyz
Labels
domain: application type: bug type: security
Milestone
Sprint 68

Comments

@clemente-xyz
Copy link
Member

Description

The lisk-desktop wallet supports only the lisk namespace; however, it does not reject WalletConnect connections that have other requiredNamespaces . As specified in WalletConnect's documentation , wallets should reject connections from dApps that request
namespaces that the wallet does not support.

Trying to sign transactions or messages with the solana methods returns an error.

Recommendation

Reject any WalletConnect connection request that requires any namespace that is different from lisk

Which version(s) does this affect? (Environment, OS, etc...)

3.0
@clemente-xyz clemente-xyz mentioned this issue Jul 14, 2023
Merged
11 tasks
@clemente-xyz clemente-xyz moved this from Backlog to In Progress in Lisk Mobile Version 3.0.0 Jul 14, 2023
@clemente-xyz clemente-xyz self-assigned this Jul 14, 2023
@clemente-xyz clemente-xyz added this to the Sprint 67 milestone Jul 14, 2023
@sridharmeganathan sridharmeganathan mentioned this issue Jul 18, 2023
Closed
97 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lisk Mobile Version 3.0.0 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemente-xyz clemente-xyz

Labels
domain: application type: bug type: security
Projects
No open projects
Lisk Mobile Version 3.0.0
Status: Done
Milestone
Sprint 68
Development

No branches or pull requests
2 participants
@clemente-xyz @sridharmeganathan
0