-
Notifications
You must be signed in to change notification settings - Fork 34
Request to add transform function to transform new data after the model has been fit. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally 8000 send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've scoped this out and started work on it - you can track the progress here. The actual logic of the transform python implementation is a bit tricky, since it relies on a ton of scipy-matrix-specific conventions for shuttling the neighbor weights around... I've roughly ported over the algorithm and I'll just have to walk through its execution to make sure it's working as intended. |
Thanks so much for working on this :)
…On Thu, Apr 25, 2019 at 10:36 PM Andy Coenen ***@***.***> wrote:
I've scoped this out and started work on it - you can track the progress
here <https://github.com/PAIR-code/umap-js/tree/transform>.
The actual logic of the transform python implementation is a bit tricky,
since it relies on a ton of scipy-matrix-specific conventions for shuttling
the neighbor weights around... I've roughly ported over the algorithm and
I'll just have to walk through its execution to make sure it's working as
intended.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKA3OUF7ALIMAE6CM2KF73PSJTCLANCNFSM4HIIC2FQ>
.
|
PR here Mind trying this out and seeing if it all works for you? |
Oh man! Awesome! I'm at a Google offsite right now but I'll try it out as
soon as I get a chance.
…On Mon., Apr. 29, 2019, 8:24 p.m. Andy Coenen, ***@***.***> wrote:
PR here <#6>
Mind trying this out and seeing if it all works for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKA3OWNT35H7QDGXMGCEFLPS6GSFANCNFSM4HIIC2FQ>
.
|
It would be great if this functionality existed in the javascript implementation as it does in the python implementation here: https://github.com/lmcinnes/umap/blob/master/umap/umap_.py#L1592
The text was updated successfully, but these errors were encountered: