8000 Master fails tests on MacOS AARCH64 · Issue #537 · PQClean/PQClean · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Master fails tests on MacOS AARCH64 #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mouse07410 opened this issue Jan 3, 2024 · 2 comments
Open

Master fails tests on MacOS AARCH64 #537

mouse07410 opened this issue Jan 3, 2024 · 2 comments

Comments

@mouse07410
Copy link
mouse07410 commented Jan 3, 2024 •
edited
Loading

Apple Silicon M2, MacOS Sonoma 14.2.1, Xcode-15.1. Current master (freshly cloned).

Sphincs-shake seems to have a problem on this platform:

clang -std=c99 -O3 -Wall -Wconversion -Werror -Wextra -Wmissing-prototypes -Wpedantic -Wredundant-decls -I../../../common  -c -o utilsx2.o utilsx2.c
utilsx2.c:91:58: error: implicit conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-conversion]
            if ((((internal_idx << 1) ^ internal_leaf) & ~0x1) == 0) {
                                                       ~ ^~~~
utilsx2.c:116:65: error: implicit conversion changes signedness: 'int' to 'unsigned int' [-Werror,-Wsign-conversion]
                               (2 / 2) * (internal_idx & ~1U) + j - left_adj + internal_idx_offset );
                                                              ~ ^
2 errors generated.
make[1]: *** [utilsx2.o] Error 1
make: *** [/Users/ur20980/src/PQClean/testcases/test_testvectors__JqjJ9FIv/crypto_bla/scheme/impl/libsphincs-shake-192s-simple_aarch64.a] Error 2

and

========================================== short test summary info ==========================================
FAILED test_compile_lib.py::test_compile_lib[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_compile_lib.py::test_compile_lib[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_dynamic_memory.py::test_dynamic_memory[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_functest.py::test_functest[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_makefile_dependencies.py::test_makefile_dependencies[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_dynamic_memory.py::test_dynamic_memory[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_dynamic_memory.py::test_dynamic_memory[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_dynamic_memory.py::test_dynamic_memory[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_functest.py::test_functest[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_dynamic_memory.py::test_dynamic_memory[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_dynamic_memory.py::test_dynamic_memory[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
FAILED test_makefile_dependencies.py::test_makefile_dependencies[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_compile_lib.py::test_compile_lib[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_functest.py::test_functest[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_makefile_dependencies.py::test_makefile_dependencies[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
FAILED test_compile_lib.py::test_compile_lib[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_compile_lib.py::test_compile_lib[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
FAILED test_makefile_dependencies.py::test_makefile_dependencies[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_functest.py::test_functest[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
FAILED test_nistkat.py::test_nistkat[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_compile_lib.py::test_compile_lib[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_nistkat.py::test_nistkat[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_nistkat.py::test_nistkat[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_symbol_namespace.py::test_symbol_namespaces[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_symbol_namespace.py::test_symbol_namespaces[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_symbol_namespace.py::test_symbol_namespaces[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
FAILED test_symbol_namespace.py::test_symbol_namespaces[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_nistkat.py::test_nistkat[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_nistkat.py::test_nistkat[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_symbol_namespace.py::test_symbol_namespaces[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_makefile_dependencies.py::test_makefile_dependencies[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_symbol_namespace.py::test_symbol_namespaces[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_functest.py::test_functest[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_testvectors.py::test_testvectors[aarch64 implementation of sphincs-shake-128f-simple] - AssertionError: Got unexpected return code 2
FAILED test_makefile_dependencies.py::test_makefile_dependencies[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_functest.py::test_functest[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_testvectors.py::test_testvectors[aarch64 implementation of sphincs-shake-256f-simple] - AssertionError: Got unexpected return code 2
FAILED test_testvectors.py::test_testvectors[aarch64 implementation of sphincs-shake-128s-simple] - AssertionError: Got unexpected return code 2
FAILED test_nistkat.py::test_nistkat[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
FAILED test_testvectors.py::test_testvectors[aarch64 implementation of sphincs-shake-256s-simple] - AssertionError: Got unexpected return code 2
FAILED test_testvectors.py::test_testvectors[aarch64 implementation of sphincs-shake-192s-simple] - AssertionError: Got unexpected return code 2
FAILED test_testvectors.py::test_testvectors[aarch64 implementation of sphincs-shake-192f-simple] - AssertionError: Got unexpected return code 2
========================= 42 failed, 1647 passed, 187 skipped in 100.46s (0:01:40) =====
@mouse07410
Copy link
Author

@thomwiggers Ping?

@thomwiggers
Copy link
Member

Fixing SPHINCS+ should probably be done while we migrate to SLH-DSA, which is #526. I just also have other things to do.

If you want to propose a standalone patch for this issue, I'd probably still merge it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomwiggers @mouse07410
0