-
Notifications
You must be signed in to change notification settings - Fork 21
[Feat] Zen Theater Mode - Non-Fullscreen fullscreen #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd suggest renaming this, something like Full Window mode or Zen Mode because there is a Theater mode already and it would cause confusion. |
Yeah, the intent is to replace theater mode with this mode. (probably) |
I'd highly advise against that. I use the current theater mode as is and prefer it over YouTube's default player. This extension is all about using YouTube in any way you want to, so taking away a feature to replace it with something else wouldn't really be wise. |
The thing is that you need some view to replace, you cannot simply create another view unless you can tie it to a key bind or something. |
Well, why not tie it to a UI button in the extension's menu, in that case? Or even better, add that UI button straight in the video player next to the other view buttons. |
I will try to work on this but I'm putting this here in case someone wants to give it a go as well.
It would be a feature that would make the theater mode view act as a tabbed full screen mode. Meaning that all the space in the tab (not screen) would be the video).
The text was updated successfully, but these errors were encountered: