8000 scripts with type="text/ecmascript-6" are not extracted · Issue #30 · PolymerLabs/crisper · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

scripts with type="text/ecmascript-6" are not extracted #30

Open
bushuyev opened this issue Jan 22, 2016 · 7 comments
Open

scripts with type="text/ecmascript-6" are not extracted #30

bushuyev opened this issue Jan 22, 2016 · 7 comments

Comments

@bushuyev
Copy link

Putting type="text/ecmascript-6" in script tag like this:

... <script type="text/ecmascript-6"> ... </script>

results in ouput file containing original <script type="text/ecmascript-6">
@arturparkhisenko
Copy link

Where you found this mime-type? links to spec https://tools.ietf.org/html/rfc4329 and thoughts http://www.2ality.com/2011/08/javascript-media-type.html
Also i found this wojtkowiak@1d78796

arturparkhisenko referenced this issue in wojtkowiak/crisper Jan 25, 2016
@wojtkowiak
Added support for finding scripts with type text/ecmascript-6
1d78796
@bushuyev
Copy link
Author

In Intellij idea:
https://intellij-support.jetbrains.com/hc/en-us/community/posts/207086715-Javascript-formatting-inside-html

@arturparkhisenko
Copy link

I think standard-only will be type="module", not type="text/babel" or type="text/ecmascript-6" or type="es6" or even some kind of jsx. And their fix in intellij-idea is just another bundler/handler/tool, it's not real spec mime-type, because we can set it to type="text/coffeescript" or type="text/jsx".
So we must just wait their decision ;) I'd prefer to stay with standard and dont blow it with all other types.

Maybe we have an analog in NPM packages of this module outside from Polymer? where we can find this functionality (i'm really looking a module which can extract css + js.. not only js like crisper does).

@bushuyev
Copy link
Author

well, anyway it's all workaround, hopefully, temporary. So nobody would be hurt much by blowing it with any sorts of types.

@arturparkhisenko
Copy link

@bushuyev to make it faster, you can make pull like in commit linked before and maybe they accept it)

@wojtkowiak
Copy link
Contributor

My pull request was already merged here: 3e043d5
Somebody just need to bump the version I guess.

@arturparkhisenko
Copy link

@wojtkowiak 👍 thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arturparkhisenko @wojtkowiak @bushuyev
0