8000 bug: invite modal param is not working · Issue #32640 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bug: invite modal param is not working #32640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zlwaterfield opened this issue May 25, 2025 · 5 comments · Fixed by #33542
Closed

bug: invite modal param is not working #32640

zlwaterfield opened this issue May 25, 2025 · 5 comments · Fixed by #33542
Assignees
@yasen-posthog
Labels
bug Something isn't working right

Comments

@zlwaterfield
Copy link
Contributor

Bug Description

We have a query param named invite_modal which is mean to open the team member invite modal when the app is loaded if it's present in the URL.

See code here:

posthog/frontend/src/scenes/settings/organization/inviteLogic.ts

Lines 174 to 180 in 2ecd810

urlToAction(({ actions }) => ({
'*': (_, searchParams) => {
if (searchParams.invite_modal) {
actions.showInviteModal()
}
},
})),

Here is what the modal looks like:
Image

It is not opening the modal, we should investigate why and get it working.

Debug info

- [ ] PostHog Cloud, Debug information: [please copy/paste from https://us.posthog.com/settings/project-details#variables or https://eu.posthog.com/settings/project-details#variables]
- [ ] PostHog Hobby self-hosted with `docker compose`, version/commit: [please provide]
- [ ] PostHog self-hosted with Kubernetes (deprecated, see [`Sunsetting Kubernetes support`](https://posthog.com/blog/sunsetting-helm-support-posthog)), version/commit: [please provide]
@zlwaterfield zlwaterfield added the bug Something isn't working right label May 25, 2025
@lshaowei18
Copy link
Contributor

Hi @zlwaterfield, could you share more details about the bug that you are facing? I tried it out and it seem to work:

Screen.Recording.2025-05-26.at.7.56.07.AM.mov
8000

@yasen-posthog yasen-posthog self-assigned this May 30, 2025
@yasen-posthog
Copy link
Contributor

I also confirm I see the feature working as expected. @zlwaterfield is there a specific page/use case you've seen this broken on?

@zlwaterfield
Copy link
Contributor Author

That's odd, I assumed it didn't work on all URLs but it looks like it may just be https://us.posthog.com/home?invite_modal=true. This URL was being used in some emails, it was reported from a customer. Can you look into why it's only happening here?

@lshaowei18
Copy link
Contributor

Hey @zlwaterfield @yasen-posthog , it seems like the redirects are not passing along the query parameter.

You can check out the list of redirects here:

posthog/frontend/src/scenes/scenes.ts

Lines 504 to 517 in 96831a0

export const redirects: Record<
string,
string | ((params: Params, searchParams: Params, hashParams: Params) => string)
> = {
'/home': urls.projectHomepage(),
'/saved_insights': urls.savedInsights(),
'/dashboards': urls.dashboards(),
'/actions': urls.actions(),
'/organization/members': urls.settings('organization'),
'/i/:shortId': ({ shortId }) => urls.insightView(shortId),
'/action/:id': ({ id }) => urls.action(id),
'/action': urls.createAction(),
'/activity': urls.activity(),
'/events': urls.activity(),

List of urls i tried that won't work:

@lshaowei18 lshaowei18 mentioned this issue May 31, 2025
Closed
1 task
@lshaowei18
Copy link
Contributor

@zlwaterfield @yasen-posthog I made #32944 to try and address the issue, feel free to close/take over, thanks!

@yasen-posthog yasen-posthog mentioned this issue Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yasen-posthog yasen-posthog

Labels
bug Something isn't working right
Projects
None yet
Milestone
No milestone
3 participants
@zlwaterfield @lshaowei18 @yasen-posthog
0