8000 bug(flags): Reordering condition sets clears out some fields · Issue #33757 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bug(flags): Reordering condition sets clears out some fields #33757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By c 8000 licking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
haacked opened this issue Jun 16, 2025 · 1 comment · Fixed by #33780
Closed

bug(flags): Reordering condition sets clears out some fields #33757

haacked opened this issue Jun 16, 2025 · 1 comment · Fixed by #33780
Labels
bug Something isn't working right feature/feature-flags Feature Tag: Feature flags team/feature-flags

Comments

@haacked
Copy link
Contributor
haacked commented Jun 16, 2025

Bug Description

Reordering condition sets seems to be broken. Fields get cleared out when moving the set.

How to reproduce

  1. Create several condition sets.
  2. Reorder them

Expected: All fields are retained.
Actual: Some fields are cleared.

Before:
Image

Click the up arrow on the second condition set

After:
Image

Additional context

Ticket: https://posthoghelp.zendesk.com/agent/tickets/32069

Debug info

- [ ] PostHog Cloud, Debug information: [please copy/paste from https://us.posthog.com/settings/project-details#variables or https://eu.posthog.com/settings/project-details#variables]
- [ ] PostHog Hobby self-hosted with `docker compose`, version/commit: [please provide]
- [ ] PostHog self-hosted with Kubernetes (deprecated, see [`Sunsetting Kubernetes support`](https://posthog.com/blog/sunsetting-helm-support-posthog)), version/commit: [please provide]
@haacked haacked added bug Something isn't working right feature/feature-flags Feature Tag: Feature flags team/feature-flags labels Jun 16, 2025
@haacked
Copy link
Contributor Author
haacked commented Jun 16, 2025

I did a little digging and it appears to be some sort of binding error.

The Kea reducers moveConditionSetUp and moveConditionSetDown are working as expected. Also, after moving a condition set and saving it, the values are there. So for some reason, when we move a condition set, some of the condition values are not being bound correctly.

@haacked haacked mentioned this issue Jun 17, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working right feature/feature-flags Feature Tag: Feature flags team/feature-flags
Projects
Feature Flags
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(flags): Add stable sorting of conditions so we can reorder them. PostHog/posthog
1 participant
@haacked
0