Runestone: remove multiple choice exercise statement from ul #2506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RS PR: RunestoneInteractive/rs#715 No real timing issues, but if RS goes first there should be no period of time with no spacing above the legend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As wondered at in the existing comment, multiplechoice questions are generating invalid HTML by placing the statement inside the
<ul>. The list should only have<li>elements:https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/ul#technical_summary
I noticed because an attempt to put a mermaid diagram in an exercise did not work correctly.
This moves the statement outside of the
<ul>and wraps it in a div. Theexercise-statementandexercise-interactivesclasses can hopefully be slowly added to RS components - currently each component has a 8000 largely unique set of styling rules.This does result in the
Choose onetext being too close to the question. Addressing that in a RS PR to also fix dark mode font color for that text.