8000 Bug: ServiceLabels not applied as labels · Pull Request #155 · PrefectHQ/prefect-operator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug: ServiceLabels not applied as labels #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

Bug: ServiceLabels not applied as labels #155

merged 2 commits into from
Apr 26, 2025

Conversation

ghost
Copy link
@ghost ghost commented Apr 20, 2025 •
edited by ghost
Loading

Resolves: #153

Changeset:

  • tools: update samples to have example labels and more samples enabled by default

Screenshots

Current Behavior:

Screenshot 2025-04-20 at 1 58 41 PM Screenshot 2025-04-20 at 1 59 42 PM

New Behavior:
Screenshot 2025-04-26 at 2 36 15 PM

@ghost ghost force-pushed the fix/service-labels branch from 25734bd to e31acba Compare April 20, 2025 19:21
feature(internal): provide comprehensive labeling
58e7467 
- extends existing unit tests to provide test coverage on labeling deployments and services
- provides labeling for previously unlabeled resources
@ghost ghost marked this pull request as ready for review April 26, 2025 19:47
@ghost ghost requested review from a team as code owners April 26, 2025 19:47
chrisguidry
chrisguidry approved these changes Apr 26, 2025
View reviewed changes
Copy link
Collaborator
@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephmcasey! Great catch, I'll get a release out shortly

@chrisguidry chrisguidry merged commit 8b56917 into PrefectHQ:main Apr 26, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: ServiceLabels not applied as labels
1 participant
@chrisguidry
0