HLSL #define not highlighted right (... or indeed overhighlighted): uniform .token.property applies, washing out the expression #3881

nabijaczleweli · 2025-03-30T13:24:36Z

Information

Language: HLSL
Plugins: none I think

Description

#define KNOWN_RGBS_FREQS
#define FREQ_LOAD
#define FREQ 1
#define TIMES_FREQ
#include "posterise_kernel.hlsl.inc"

#define KNOWN_RGBS_FREQS [[vk::binding(3, 0)]] StructuredBuffer<uint4> known_rgbs_freqs;
#define FREQ_LOAD        uint freq = known_rgbs_freqs[i / 4][i % 4];
#define FREQ             freq
#define TIMES_FREQ       * freq
#include "posterise_kernel.hlsl.inc"

(Twilight theme)

This is fully washed-out: the macro content has lost all high-lighting (by virtue of uint4 being the same colour as everything else), and the macro name is high-lighted as-if it were a keyword but it's a variable (Prism.js variables are unhighlighted in general).

GitHub does a passable job of highlighting this correctly, here's a mock-up of how it makes sense, to high-light it, too me:

Code snippet

Test page

nabijaczleweli · 2025-03-30T13:53:39Z

FWIW, since the structure is thus:

I'm patching this by adding a

[class="language-hlsl"] .token.macro.property {
  color: inherit;
}

style override and a

.replace(/<span class="token directive-hash">#<\/span><span class="token directive keyword">/g, '<span class="token directive keyword">#')

if language == "hlsl" post-processing step that yields results equivalent to the mock-up.

nabijaczleweli added the language-definitions label Mar 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HLSL #define not highlighted right (... or indeed overhighlighted): uniform .token.property applies, washing out the expression #3881

HLSL #define not highlighted right (... or indeed overhighlighted): uniform .token.property applies, washing out the expression #3881

Uh oh!

HLSL #define not highlighted right (... or indeed overhighlighted): uniform .token.property applies, washing out the expression #3881

HLSL #define not highlighted right (... or indeed overhighlighted): uniform .token.property applies, washing out the expression #3881

Comments

Uh oh!

Uh oh!