8000 Repo does not seem to be setup properly to track changes/diffs · Issue #3 · ProjectOpenSea/seaport-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Repo does not seem to be setup properly to track changes/diffs #3
Open
@Saw-mon-and-Natalie

Description

@Saw-mon-and-Natalie

When looking at the diffs between the original Seaport repo and this new one. Some core files have been removed and recreated instead of being moved. This would make tracking changes more difficult:

git diff --compact-summary spearbit-audit-2022-12 1.5.0 | grep -E "(contracts|src\/)" | grep -v "test"
 contracts/conduit/lib/ConduitConstants.sol (gone)  |   18 -
 contracts/conduit/lib/ConduitEnums.sol (gone)      |    9 -
 contracts/conduit/lib/ConduitStructs.sol (gone)    |   21 -
 contracts/helpers/TransferHelperStructs.sol (gone) |   29 -
 contracts/interfaces/ConduitInterface.sol (gone)   |   96 -
 contracts/interfaces/EIP1271Interface.sol (gone)   |    9 -
 contracts/interfaces/IERC721Receiver.sol (gone)    |   11 -
 contracts/interfaces/ReentrancyErrors.sol (gone)   |   15 -
 contracts/interfaces/SeaportInterface.sol (gone)   |  442 --
 contracts/interfaces/ZoneInterface.sol (gone)      |   16 -
 contracts/lib/Assertions.sol (gone)                |  175 -
 contracts/lib/Consideration.sol (gone)             |  627 --
 contracts/lib/ConsiderationBase.sol (gone)         |  280 -
 contracts/lib/ConsiderationConstants.sol (gone)    |  952 ---
 contracts/lib/ConsiderationDecoder.sol (gone)      |  757 --
 contracts/lib/ConsiderationEncoder.sol (gone)      |  478 --
 contracts/lib/ConsiderationEnums.sol (gone)        |  146 -
 contracts/lib/ConsiderationErrors.sol (gone)       |  498 --
 contracts/lib/ConsiderationStructs.sol (gone)      |  538 --
 contracts/lib/FulfillmentApplier.sol (gone)        |  770 --
 contracts/lib/LowLevelHelpers.sol (gone)           |  164 -
 contracts/lib/OrderValidator.sol (gone)            |  743 --
 contracts/lib/PointerLibraries.sol (gone)          | 3084 --------
 contracts/lib/ReentrancyGuard.sol (gone)           |   57 -
 contracts/lib/TokenTransferrerConstants.sol (gone) |  184 -
 contracts/lib/TypehashDirectory.sol (gone)         |  123 -
 contracts/lib/ZoneInteraction.sol (gone)           |  255 -
 contracts/zones/PausableZone.sol (gone)            |  225 -
 contracts/zones/PausableZoneController.sol (gone)  |  379 -
 lib/openzeppelin-contracts (gone)                  |    1 -
 {contracts => src}/Seaport.sol                     |   20 +-
 {contracts => src}/conduit/Conduit.sol             |   68 +-
 {contracts => src}/conduit/ConduitController.sol   |   98 +-
 src/helpers/SeaportRouter.sol (new)                |  224 +
 {contracts => src}/helpers/TransferHelper.sol      |  126 +-
 {contracts => src}/lib/AmountDeriver.sol           |   48 +-
 src/lib/Assertions.sol (new)                       |  209 +
 {contracts => src}/lib/BasicOrderFulfiller.sol     |  818 +-
 src/lib/Consideration.sol (new)                    |  734 ++
 src/lib/ConsiderationBase.sol (new)                |  402 +
 src/lib/ConsiderationDecoder.sol (new)             | 1185 +++
 src/lib/ConsiderationEncoder.sol (new)             |  655 ++
 {contracts => src}/lib/CounterManager.sol          |   28 +-
 {contracts => src}/lib/CriteriaResolution.sol      |  153 +-
 {contracts => src}/lib/Executor.sol                |  341 +-
 src/lib/FulfillmentApplier.sol (new)               |  650 ++
 {contracts => src}/lib/GettersAndDerivers.sol      |  157 +-
 src/lib/LowLevelHelpers.sol (new)                  |  101 +
 {contracts => src}/lib/OrderCombiner.sol           |  704 +-
 {contracts => src}/lib/OrderFulfiller.sol          |  208 +-
 src/lib/OrderValidator.sol (new)                   |  822 ++
 src/lib/ReentrancyGuard.sol (new)                  |   83 +
 {contracts => src}/lib/SignatureVerification.sol   |  177 +-
 {contracts => src}/lib/TokenTransferrer.sol        |  575 +-
 {contracts => src}/lib/Verifiers.sol               |  168 +-
 src/lib/ZoneInteraction.sol (new)                  |  220 +

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0