8000 FlipFace issues · Issue #661 · RayTracing/raytracing.github.io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FlipFace issues #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Walther opened this issue Jul 8, 2020 · 4 comments
Closed

FlipFace issues #661

Walther opened this issue Jul 8, 2020 · 4 comments
Assignees
@trevordblack
Labels
area: book book 3: Your Life
Milestone
v3.2.0

Comments

@Walther
Copy link
Walther commented Jul 8, 2020

In Book 2 (the published version) there is a chapter on flipping objects. With the other improvements and changes that have been made to the tutorial, it apparently isn't necessary anymore; the first attempt of Cornell box renders correctly with all faces visible. (This caused some extra debugging - "why does this work even if it shouldn't yet?")

Apparently, in #602, the relevant parts have been already removed, but the published version online still has it. That part could be easily fixed by doing a publish some day when the new version is complete.

However! In Book 3, the flipface usage is reintroduced in order to make the rectangle-shaped light one-sided, to avoid bleed-through in the ceiling. Currently, Book 3 has no code for it. When the currently-merged version of Book 2 gets published, there will be no place for a reader to find the flip face methods. Perhaps a tiny remark, but something that occurred to me 😄
@hollasch
Copy link
Collaborator
hollasch commented Jul 8, 2020

Youch! Didn't catch that problem. We'll have to at least add a note for v3.2.0, and hopefully fix this up in v3.3.0 or later.

@hollasch hollasch added this to the v3.2.0 milestone Jul 8, 2020
@trevordblack trevordblack mentioned this issue Jul 8, 2020
Closed
@trevordblack
Copy link
Collaborator

I'm splitting this into two issues:

  1. Removing Chapter 7.7 from book 2 AND giving an example flipface source for chapter 3. We don't need something pretty here, but I'm going to demand that we have the source (this issue).
  2. Rewriting Book3 to allow for flipface when flipping the light (Rewrite Book 3 to allow for flipping faces of Cornell Light #662)

@trevordblack trevordblack self-assigned this Jul 8, 2020
@trevordblack
Copy link
Collaborator

I'm actually going to renege on my own demands.
I'm going to drop the source for flip_face into the text of book 3, but I'm not going to explain how it's used or where it goes.

Quite frankly, the source in Book 3 needs a lot of work before an explanation is possible.
PR incoming

@trevordblack
Copy link
Collaborator

Okay, I lied. I figured it out literally seconds later.
PR incommmming....

@trevordblack trevordblack mentioned this issue Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevordblack trevordblack

Labels
area: book book 3: Your Life
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
3 participants
@hollasch @Walther @trevordblack
0