8000 Address `material::scatter()` function mismatch between book and source · Issue #669 · RayTracing/raytracing.github.io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Address material::scatter() function mismatch between book and source #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hollasch opened this issue Jul 15, 2020 · 1 comment
Closed

Address material::scatter() function mismatch between book and source #669

hollasch opened this issue Jul 15, 2020 · 1 comment
Assignees
@trevordblack
Labels
area: book area: code book 3: Your Life level: major
Milestone
v4.0.0

Comments

@hollasch
Copy link
Collaborator
  • Book two has a material::scatter() method that takes four arguments.
  • Book three text has a material::scatter() method that adds a fifth argument.
  • Book three source has a material::scatter() method that takes three arguments.

Also note that the original isotropic::scatter() method in book three took four arguments, so the source code was actually invoking the default material::scatter() method, so that image is probably wrong.
@hollasch hollasch added this to the v3.3.0 milestone Jul 15, 2020
This was referenced Jul 15, 2020
Closed
Closed
@trevordblack trevordblack self-assigned this Jul 27, 2020
@hollasch hollasch modified the milestones: v3.3.0, Backlog, v4.0.0 Oct 12, 2020
trevordblack added a commit that referenced this issue Apr 13, 2021
@trevordblack
Added isotropic changes for book 3. Made some changes to prior books.
d043154 
Resolves #664, #669
@trevordblack trevordblack mentioned this issue Apr 13, 2021
Merged
trevordblack added a commit that referenced this issue Apr 15, 2021
@trevordblack
Added isotropic changes for book 3. Made some changes to prior books.
3ab99ec 
Resolves #664, #669
@trevordblack
Copy link
Collaborator

This can probably be closed out with the merge of #885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevordblack trevordblack

Labels
area: book area: code book 3: Your Life level: major
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@hollasch @trevordblack
0