feat(search): swap sqlSearch with scout search for users #3507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
May 14, 2025
app/Models/User.php
Outdated
| @@ -314,7 +314,10 @@ public function getActivitylogOptions(): LogOptions | |||
| public function toSearchableArray(): array | |||
| { | |||
| return [ | |||
| 'banned_at' => $this->banned_at, | |||
| 'deleted_at' => $this->Deleted, | |||
There was a problem hiding this comment.
Wouldn't it make more sense to have these drive the shouldBeSearchable property?
There was a problem hiding this comment.
Yep, it would. Fixed in latest. To test, after pulling latest from the branch, start Horizon, and then:
sail artisan scout:sync-index-settings
sail artisan scout:flush "App\Models\User"
sail artisan scout:import "App\Models\User"
Jamiras
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔴 Should be deployed separately from #3491.
This PR drops
User::scopeSqlSearch()in favor ofUser::search()powered by Meilisearch. The weighting isn't exactly how it was before, but it's probably good enough.How to test this PR:
Now navigate to http://localhost:64000/messages/create and start searching for users.
Performance before: ~389ms
Performance after: ~135ms