10000 All files highlight on explorer tab when using `json` instead of `path` in settings · Issue #274 · RhoInc/web-codebook · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

All files highlight on explorer tab when using json instead of path in settings #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jwildfire opened this issue Jul 11, 2018 · 2 comments
Closed

All files highlight on explorer tab when using json instead of path in settings #274

jwildfire opened this issue Jul 11, 2018 · 2 comments
Assignees
@jwildfire
Labels
bug
Milestone
v1.4.1

Comments

@jwildfire
Copy link
Contributor

This shows up - and looks ugly - in the R-based codebook repo explorer() widget as shown.

screen shot 2018-07-11 at 6 32 16 am
@jwildfire jwildfire self-assigned this Jul 11, 2018
@jwildfire jwildfire added this to the v1.4.1 milestone Jul 11, 2018
@jwildfire jwildfire added the bug label Jul 11, 2018
@jwildfire jwildfire mentioned this issue Jul 11, 2018
Closed
@jwildfire
Copy link
Contributor Author

Problem is here, where we're using path to define the selected file.

@jwildfire jwildfire mentioned this issue Jul 11, 2018
Merged
@jwildfire
Copy link
Contributor Author
jwildfire commented Jul 11, 2018 •
edited
Loading

Test Notes

  • Confirm that only one file highlights and that basic file tab functionality is working when using path setting (you can use /build/test-page/explorer.html)
  • Confirm that only one file highlights and that basic file tab functionality is working using the json settings, like in the code below:
  var testjson1 = [{"row":1,"name":"alex"},{"row":2,"name":"george"}]
  var testjson2 = [{"row":3,"name":"becca"},{"row":4,"name":"agustin"}]

  var testSettings  = {
    labelColumn:"Dataset",
    ignoredColumns:[],
    files:[
      {Dataset:"test1",json:testjson1},
      {Dataset:"test2",json:testjson2}
    ],
    meta:[]
};
var explorer = webcodebook.createExplorer(el, jsSettings).init();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwildfire jwildfire

Labels
bug
Projects
None yet
Milestone
v1.4.1
Development

No branches or pull requests
1 participant
@jwildfire
0