nom::be_u32 is used instead of the nom::le_u32

According to the original unrar sources Little-endian should be used there:

Lines 152 to 161 in b84da66

    
           /// get a base header 
        
           named!(base_header(&[u8]) -> (HeadBlock),  
        
               do_parse!( 
        
                   crc: be_u32 >> 
        
                   size: vint >> 
        
                   typ: vint >> 
        
                   flags: vint >> 
        
                   (HeadBlock::new(crc, size, typ.into(), flags.into())) 
        
               ) 
        
           );

RAR/src/file_block.rs

Lines 68 to 79 in b84da66

    
           if file.flags.time { 
        
               let (i, mtime) = be_u32(input)?; 
        
               input = i; 
        
               file.mtime = mtime; 
        
           } 
        
           // check for file crc data 
        
           if file.flags.crc { 
        
               let (i, crc) = be_u32(input)?; 
        
               input = i; 
        
               file.data_crc = crc; 
        
           }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	/// get a base header
	named!(base_header(&[u8]) -> (HeadBlock),
	do_parse!(
	crc: be_u32 >>
	size: vint >>
	typ: vint >>
	flags: vint >>
	(HeadBlock::new(crc, size, typ.into(), flags.into()))
	)
	);

	if file.flags.time {
	let (i, mtime) = be_u32(input)?;
	input = i;
	file.mtime = mtime;
	}

	// check for file crc data
	if file.flags.crc {
	let (i, crc) = be_u32(input)?;
	input = i;
	file.data_crc = crc;
	}

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions